From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14288 invoked by alias); 4 Nov 2004 15:16:21 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14269 invoked from network); 4 Nov 2004 15:16:17 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 4 Nov 2004 15:16:17 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1CPjLV-0007MV-C2; Thu, 04 Nov 2004 10:16:17 -0500 Date: Thu, 04 Nov 2004 15:16:00 -0000 From: Daniel Jacobowitz To: Jim Blandy Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: avoid creating inter-objfile type pointers Message-ID: <20041104151617.GA28125@nevyn.them.org> Mail-Followup-To: Jim Blandy , gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-11/txt/msg00061.txt.bz2 On Thu, Nov 04, 2004 at 02:12:19AM -0500, Jim Blandy wrote: > > This fixes a bug that causes incorrect output and crashes, and which > is not caught by the current test suite. A test could be easily added > to shlib-call.exp to catch this; I'll try to give that a shot in a > bit. > > 2004-11-04 Jim Blandy > > * gdbtypes.c (make_qualified_type): Doc fix. Add assertion to > prevent cross-objfile references. > (make_cv_type): Doc fix. Don't create cross-objfile references, > even for stub types. > (replace_type): Add assertion to prevent cross-objfile references. > (check_typedef): Never resolve a stub type by copying over a type > from another file. Oopsie. This looks sane to me. -- Daniel Jacobowitz