[RFA/testsuite] Stop sharing .c file between 2 testcases

Joel Brobecker
2004-10-29T17:02:46Z

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

I just read in one thread that we don't want to share .c files between
testcases. This reminded me of a testcase I recently added which did
use the .c file from another testcase... This patch should fix it.

2004-10-29 Joel Brobecker <brobecker@gnat.com>

* gdb.threads/bp_in_thread.c: New file, copied from
pthread_cond_wait.c.
* gdb.threads/bp_in_thread.c: Use bp_in_thread.c as the source
file, rather than using the .c file of another testcase.

Tested on x86-linux. Ok to apply?

--
Joel

[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 521 bytes --]

Index: bp_in_thread.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/bp_in_thread.exp,v
retrieving revision 1.2
diff -u -p -r1.2 bp_in_thread.exp
--- bp_in_thread.exp 11 Oct 2004 12:22:33 -0000 1.2
+++ bp_in_thread.exp 29 Oct 2004 17:02:12 -0000
@@ -23,7 +23,7 @@ if $tracelevel then {
strace $tracelevel
}

-set testfile "pthread_cond_wait"
+set testfile "bp_in_thread"
set srcfile ${testfile}.c
set binfile ${objdir}/${subdir}/${testfile}

[-- Attachment #3: bp_in_thread.c --]
[-- Type: text/plain, Size: 1712 bytes --]

/* A small multi-threaded test case.

Copyright 2004
Free Software Foundation, Inc.

This file is part of GDB.

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */

#include <pthread.h>
#include <stdio.h>
#include <time.h>

void
cond_wait (pthread_cond_t *cond, pthread_mutex_t *mut)
{
pthread_mutex_lock(mut);
pthread_cond_wait (cond, mut);
pthread_mutex_unlock (mut);
}

void
noreturn (void)
{
pthread_mutex_t mut;
pthread_cond_t cond;

pthread_mutex_init (&mut, NULL);
pthread_cond_init (&cond, NULL);

/* Wait for a condition that will never be signaled, so we effectively
block the thread here. */
cond_wait (&cond, &mut);
}

void *
forever_pthread (void *unused)
{
noreturn ();
}

void
break_me (void)
{
/* Just an anchor to help putting a breakpoint. */
}

int
main (void)
{
pthread_t forever;
const struct timespec ts = { 0, 10000000 }; /* 0.01 sec */

pthread_create (&forever, NULL, forever_pthread, NULL);
for (;;)
{
nanosleep (&ts, NULL);
break_me();
}

return 0;
}