From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27301 invoked by alias); 29 Oct 2004 15:36:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27269 invoked from network); 29 Oct 2004 15:35:59 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 29 Oct 2004 15:35:59 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1CNYn3-0007k5-BE; Fri, 29 Oct 2004 11:35:45 -0400 Date: Fri, 29 Oct 2004 15:36:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: Felix Lee , gdb-patches@sources.redhat.com Subject: Re: backtrace changes current source location Message-ID: <20041029153544.GA29627@nevyn.them.org> Mail-Followup-To: Andrew Cagney , Felix Lee , gdb-patches@sources.redhat.com References: <20041026075115.4A2C354AAB5@stray.canids> <20041026132924.GA26886@nevyn.them.org> <20041026150127.6ED3E54AAB5@stray.canids> <417FDC11.7060700@gnu.org> <20041028005157.259D34E8F0A@stray.canids> <41825FD5.1030607@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41825FD5.1030607@gnu.org> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-10/txt/msg00479.txt.bz2 On Fri, Oct 29, 2004 at 11:20:53AM -0400, Andrew Cagney wrote: > Hmm, things have changed. > > Felix Lee wrote: > >Andrew Cagney : > > > >>(Don't forget to consider the error case - if an error is thrown a > >>restore would be lost) > > > > > >is it worth setting up an unwind handler for that? I couldn't > >think of a case where an error would be usual, and for unusual > >errors, all bets are off. > > As a debugger, we're no longer going to gamble with the user interface - > even when there's an error the behavior should be well defined. > > Can you find out why selected sal is being corrupted, code shouldn't be > modifying it. I wrote: On Wed, Oct 27, 2004 at 01:34:09PM -0400, Andrew Cagney wrote: > Felix Lee wrote: > >patch for > > http://sources.redhat.com/ml/gdb/2004-10/msg00414.html > > > >gdb/ChangeLog > >2004-10-26 Felix Lee > > > > * stack.c (backtrace_command_1): Backtrace shouldn't > > change current source location. > > Felix, can you find out where current_sal is being trashed? GDB's > trying to get away from all this global state - the code at that level > shouldn't need to meddle with current_sal. If you follow the link in his message above, Keith introduced it in 2002 - print_frame_info_base. Does that answer your question? -- Daniel Jacobowitz