Re: gdbserver build broken on amd64-linux

[Joel Brobecker <brobecker@gnat.com>]

[-- Attachment #1: Type: text/plain, Size: 945 bytes --]

> Joel, could you test the #ifndef version and check it in?

I verified that the attached patch allows gdbserver to build,
and I also double-checked the values with the ones I have in
my prctl.h file. But I've never used gdbserver before, and when
I tried it, I had a failure:

    (gdb) target remote localhost:2345
    Remote debugging using localhost:2345
    Couldn't establish connection to remote target
    Remote register badly formatted: T0506:0000000000000000;07:c0f1ffbf7f000000;10:2
    06f55952a000000;
    here: 0000000;07:c0f1ffbf7f000000;10:206f55952a000000;

Not sure why there seems to be discrepancy in the protocol...
In any case, I checked in this patch, since it can only be correct.

2004-10-20  Joel Brobecker  <brobecker@gnat.com>

        * linux-x86-64-low.c (ARCH_SET_GS): Add definition if missing.
        (ARCH_SET_FS): Likewise.
        (ARCH_GET_FS): Likewise.
        (ARCH_GET_GS): Likewise.

Thanks,
-- 
Joel

[-- Attachment #2: linux-x86-64-low.c.diff --]
[-- Type: text/plain, Size: 736 bytes --]

Index: linux-x86-64-low.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/linux-x86-64-low.c,v
retrieving revision 1.8
diff -u -p -r1.8 linux-x86-64-low.c
--- linux-x86-64-low.c	16 Oct 2004 17:42:00 -0000	1.8
+++ linux-x86-64-low.c	21 Oct 2004 04:05:38 -0000
@@ -47,6 +47,15 @@
 #define PTRACE_ARCH_PRCTL      30
 #endif
 
+/* The following definitions come from prctl.h, but may be absent
+   for certain configurations.  */
+#ifndef ARCH_GET_FS
+#define ARCH_SET_GS 0x1001
+#define ARCH_SET_FS 0x1002
+#define ARCH_GET_FS 0x1003
+#define ARCH_GET_GS 0x1004
+#endif
+
 static int x86_64_regmap[] = {
   RAX * 8, RBX * 8, RCX * 8, RDX * 8,
   RSI * 8, RDI * 8, RBP * 8, RSP * 8,