From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18745 invoked by alias); 20 Oct 2004 15:53:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18737 invoked from network); 20 Oct 2004 15:53:24 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 20 Oct 2004 15:53:24 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1CKIm5-0004fa-BZ; Wed, 20 Oct 2004 11:53:17 -0400 Date: Wed, 20 Oct 2004 15:53:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: brobecker@gnat.com, gdb-patches@sources.redhat.com Subject: Re: gdbserver build broken on amd64-linux Message-ID: <20041020155316.GA17828@nevyn.them.org> Mail-Followup-To: Mark Kettenis , brobecker@gnat.com, gdb-patches@sources.redhat.com References: <20041020053216.GB3527@gnat.com> <20041020142645.GA24010@nevyn.them.org> <20041020152441.GD3527@gnat.com> <200410201547.i9KFl8i6022712@elgar.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410201547.i9KFl8i6022712@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-10/txt/msg00339.txt.bz2 On Wed, Oct 20, 2004 at 05:47:08PM +0200, Mark Kettenis wrote: > Date: Wed, 20 Oct 2004 08:24:41 -0700 > From: Joel Brobecker > > > How about ths instead? > > > > #ifndef ARCH_GET_FS > > #define ARCH_SET_GS 0x1001 > > #define ARCH_SET_FS 0x1002 > > #define ARCH_GET_FS 0x1003 > > #define ARCH_GET_GS 0x1004 > > #endif > > That's better, since it's dangerous to include kernel headers > directly. > > Yes, that should work too. I'm curious as to why these macros are not > defined for me, or said differently how it is that they are defined for > others (assuming others can build this code on amd64-linux unmodified). > > It all depends on the combination of installed kernel headers and > glibc headers whether it'll work or not. There are broken > combinations out there, even on i386. It's inherent to the way > GNU/Linux is developped since there is no real attempt to keep kernel > and libc in sync. Learn to live with or switch to a free > operating system with decent release management . While your accusation is generally valid, in this case Joel hit the salient point: (assuming others can build this code on amd64-linux unmodified) Since I wrote that code before I got an amd64-linux machine (long time ago), and didn't test it on one before I checked it in, it's my own stupid fault. I assumed that would include , whch does not seem to be the case. Joel, could you test the #ifndef version and check it in? -- Daniel Jacobowitz