From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9794 invoked by alias); 20 Oct 2004 14:26:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9712 invoked from network); 20 Oct 2004 14:26:46 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 20 Oct 2004 14:26:46 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1CKHQL-0006IL-Dt; Wed, 20 Oct 2004 10:26:45 -0400 Date: Wed, 20 Oct 2004 14:26:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: gdbserver build broken on amd64-linux Message-ID: <20041020142645.GA24010@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20041020053216.GB3527@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041020053216.GB3527@gnat.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-10/txt/msg00336.txt.bz2 On Tue, Oct 19, 2004 at 10:32:16PM -0700, Joel Brobecker wrote: > The compiler fails to find a couple of macros: > > > gcc -c -Wall -g -O2 -I. -I. -I./../regformats -I./../../include -I../../bfd -I./../../bfd linux-x86-64-low.c > > linux-x86-64-low.c: In function 'ps_get_thread_area': > > linux-x86-64-low.c:70: error: 'ARCH_GET_FS' undeclared (first use in this function) > > linux-x86-64-low.c:70: error: (Each undeclared identifier is reported only once > > linux-x86-64-low.c:70: error: for each function it appears in.) > > linux-x86-64-low.c:74: error: 'ARCH_GET_GS' undeclared (first use in this function) > > I found the definitions in asm-x86_64/prctl.h. So I #included that file, > and the build succeeded. Looking at the name, I wasn't too enthusiastic > about it, as it didn't look too standard, so I looked around, and saw > that this file is included from asm/prctl.h. So I changed the #include > to that file instead, and got the builds again. > > 2004-10-19 Joel Brobecker > > * linux-x86-64-low.c: Include asm/prctl.h. > > I hope this is the right fix, but at the same time, I can't help but > wonder how it did work before... Let me know if this is OK to apply > or if it is the wrong fix (I am hoping that the location of these > macros is not dependent on the Linux distribution). How about ths instead? #ifndef ARCH_GET_FS #define ARCH_SET_GS 0x1001 #define ARCH_SET_FS 0x1002 #define ARCH_GET_FS 0x1003 #define ARCH_GET_GS 0x1004 #endif -- Daniel Jacobowitz