From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2761 invoked by alias); 20 Oct 2004 11:03:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2743 invoked from network); 20 Oct 2004 11:03:04 -0000 Received: from unknown (HELO walton.sibelius.xs4all.nl) (82.92.89.47) by sourceware.org with SMTP; 20 Oct 2004 11:03:04 -0000 Received: from elgar.sibelius.xs4all.nl (elgar.sibelius.xs4all.nl [192.168.0.2]) by walton.sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id i9KB2qNd031910; Wed, 20 Oct 2004 13:02:52 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (localhost [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6) with ESMTP id i9KB2qXL021817; Wed, 20 Oct 2004 13:02:52 +0200 (CEST) (envelope-from kettenis@elgar.sibelius.xs4all.nl) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6/Submit) id i9KB2pA2021814; Wed, 20 Oct 2004 13:02:51 +0200 (CEST) Date: Wed, 20 Oct 2004 11:03:00 -0000 Message-Id: <200410201102.i9KB2pA2021814@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: jjohnstn@redhat.com CC: gdb-patches@sources.redhat.com In-reply-to: <4175A9C9.8040300@redhat.com> (message from Jeff Johnston on Tue, 19 Oct 2004 19:56:57 -0400) Subject: Re: [RFA]: Watchpoints per thread patch References: <4175A9C9.8040300@redhat.com> X-SW-Source: 2004-10/txt/msg00331.txt.bz2 Date: Tue, 19 Oct 2004 19:56:57 -0400 From: Jeff Johnston The following patch adds needed support for the ia64 and s390 platforms. For these platforms, watchpoints need to be inserted / removed on each thread so as to work across all threads. The patch adds support for detecting this at configuration time and setting a new flag WATCHPOINTS_PER_THREAD. This flag is used when inserting/removing watchpoints and when a new thread event occurs. Jeff, this is almost certainly the wrong way to implement this. Firstly you're treating this as a generic feature of the ia64 and s390 platforms, while in fact it's a feature of the Linux kernel. It's true that we don't really support anything but Linux on ia64 and s390, but that will certainly change in the near feature when FreeBSD/ia64 support will be integrated. Secondly, you're setting the flag whenever the host is ia64 or s390. Have you thought about what will happen if you build a cross-debugger on one of these platforms? Thirdly, I'm not really charmed about your choice to do this waith a global #define that you set in configure. Eli already told you that it's not very autoconfy, but it also causes us to conditionally compile parts of the code only on certain platforms. This is not the direction in which we're heading. Have you thought about implementing an observer for new threads and using that to set the breakpoints in a new thread? Cheers, Mark