From: Joel Brobecker <brobecker@gnat.com>
To: Michael Snyder <msnyder@redhat.com>
Cc: gdb-patches@sources.redhat.com,
Kevin Buettner <kevinb@redhat.com>,
jimb@redhat.com
Subject: Re: [RFA] ppc/rs6000: use gdbarch_ps_regnum
Date: Sat, 16 Oct 2004 03:23:00 -0000 [thread overview]
Message-ID: <20041016032257.GZ1375@gnat.com> (raw)
In-Reply-To: <20041016010827.GY1375@gnat.com>
> > 2004-10-15 Michael Snyder <msnyder@redhat.com>
> >
> > * ppc-tdep.h (struct gdbarch_tdep): Remove ppc_ps_regnum.
> > * rs6000-tdep.c (rs6000_gdbarch_init): Use set_gdbarch_ps_regnum
> > instead of putting it in the tdep struct.
> > * rs6000-nat.c: Use PS_REGNUM instead of the tdep.
> > * ppc-linux-nat.c: Ditto.
> > * ppc-linux-tdep.c: Ditto.
> > * aix-thread.c: Ditto.
>
> Seems good to me (pretty obvious actually), but I'd prefer it if Kevin
> approved it too. Give him a week, and then check it in.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Ahem, big blush, it just occured to me that these files do not even
remotely fall under AIX maintainership. So please ignore my go ahead,
I was confused by being Cc'ed.
> Currently testing on AIX 5.1 right now. Will send the results as soon
> as they are available.
Results are good. No regression.
--
Joel
next prev parent reply other threads:[~2004-10-16 3:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-16 0:41 Michael Snyder
2004-10-16 1:08 ` Joel Brobecker
2004-10-16 3:23 ` Joel Brobecker [this message]
2004-10-16 6:18 ` Kevin Buettner
2004-10-18 20:32 ` Michael Snyder
2004-10-25 23:25 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041016032257.GZ1375@gnat.com \
--to=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
--cc=kevinb@redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox