Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: [PATCH/mips] small code reordering...
Date: Fri, 15 Oct 2004 07:30:00 -0000	[thread overview]
Message-ID: <20041015073045.GP1375@gnat.com> (raw)

Hello,

The attached patch does a bit of code reordering. The idea was to
get rid of the following FIXME introduced in the previous change
(to avoid bloating the patch with code-moving changes):

    /* FIXME: brobecker/2004-10-15: I suspect these two declarations can
       be removed by a better ordering of the functions below.  But I want
       to do that as a separate change later in order to separate real
       changes and changes that just move some code around.  */

It turns out that I find the new location to be more natural anyway,
so I think the move was more than worthwhile.

Sorry for the obfuscated diff. It's just all cut, move, paste actions.

2004-10-15  Joel Brobecker  <brobecker@gnat.com>

        * mips-tdep.c (mips32_scan_prologue): Move the implementation up
        a bit to avoid the necessity of an advance declaration. Remove
        declaration.
        (set_reg_offset): Move implemenation up.
        (mips16_get_imm): Likewise.
        (mips16_scan_prologue): Likewise.
        (reset_saved_regs): Likewise.
        (mips32_scan_prologue): Likewise.

Comitted.

-- 
Joel


             reply	other threads:[~2004-10-15  7:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-15  7:30 Joel Brobecker [this message]
2004-10-15 14:04 ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041015073045.GP1375@gnat.com \
    --to=brobecker@gnat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox