From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3894 invoked by alias); 13 Oct 2004 11:30:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3879 invoked from network); 13 Oct 2004 11:30:47 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 13 Oct 2004 11:30:47 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i9DBUl03005341 for ; Wed, 13 Oct 2004 07:30:47 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i9DBUkr19169 for ; Wed, 13 Oct 2004 07:30:46 -0400 Received: from cygbert.vinschen.de (vpn50-25.rdu.redhat.com [172.16.50.25]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id i9DBUi0O021755 for ; Wed, 13 Oct 2004 07:30:45 -0400 Received: by cygbert.vinschen.de (Postfix, from userid 500) id 81E9058090; Wed, 13 Oct 2004 13:31:45 +0200 (CEST) Date: Wed, 13 Oct 2004 11:30:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] sh-tdep.c: Begin evaluating calling_convention Message-ID: <20041013113145.GF6702@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <416D0D57.3030807@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <416D0D57.3030807@st.com> User-Agent: Mutt/1.4.2i X-SW-Source: 2004-10/txt/msg00229.txt.bz2 On Oct 13 12:11, Joern RENNECKE wrote: > >static const char *sh_active_calling_convention = sh_cc_auto; > > Shouldn't this go into the tdep struct? Can you expand a bit? This setting reflects what has been set on the UI level. It's not quite clear to me why this should go into the tdep struct. The actually used calling_convention is evaluated in the sh_effective_calling_convention function which uses the setting of sh_active_calling_convention only if the user overrides the default on the UI level. Otherwise the calling convention is a function specific thingy anyway. Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat, Inc.