From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14259 invoked by alias); 13 Oct 2004 09:30:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14250 invoked from network); 13 Oct 2004 09:30:46 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 13 Oct 2004 09:30:46 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i9D9Ujjv007403 for ; Wed, 13 Oct 2004 05:30:45 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i9D9Ujr26261 for ; Wed, 13 Oct 2004 05:30:45 -0400 Received: from cygbert.vinschen.de (vpn50-25.rdu.redhat.com [172.16.50.25]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id i9D9Uh0O017349 for ; Wed, 13 Oct 2004 05:30:43 -0400 Received: by cygbert.vinschen.de (Postfix, from userid 500) id 294E658090; Wed, 13 Oct 2004 11:31:44 +0200 (CEST) Date: Wed, 13 Oct 2004 09:30:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] Change gdbarch_return_value to take function type instead of return value type Message-ID: <20041013093144.GE18268@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <20041012124916.GZ6702@cygbert.vinschen.de> <200410122215.i9CMFcfN003173@elgar.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410122215.i9CMFcfN003173@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.4.2i X-SW-Source: 2004-10/txt/msg00225.txt.bz2 Hi Mark, On Oct 13 00:15, Mark Kettenis wrote: > The patch looks OK to me. > > There's also an important change necessary to sparc-tdep.c. sparc32 is the > only platform which calls using_struct_return from push_dummy_code. Since > push_dummy_code only has the return value type, it can neither call > using_struct_return nor gdbarch_return_value. I've created a new static > function called "sparc32_using_struct_return" which only evaluates whether > a struct return condition exists or not. The function is now used in > sparc32_push_dummy_code as well as in sparc32_return_value. > > I think that for HP-UX, push_dummy_call needs to get passed the > function as a `struct value'. That could clean up things a bit > further. However, that's not for you to worry about. So please check > this in. I'm a bit confused. The patch to sparc-tdep.c affects push_dummy_*code*, not push_dumm_*call*. The push_dummy_call definition has already been changed to using `struct value *function' by Randlph Chung on 2004-06-06. push_dummy_code still gets a `struct type *return_type' only. So while my patch handles the immediate consequences of the gdbarch_return_value parameter change, it might be useful in the long run to change push_dummy_code to get either the function value or the function type as well. Otherwise, thanks for approving the patch, I'll check it in in a few minutes. Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat, Inc.