From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25976 invoked by alias); 12 Oct 2004 14:42:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25964 invoked from network); 12 Oct 2004 14:42:44 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 12 Oct 2004 14:42:44 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1CHNrP-0007nW-So; Tue, 12 Oct 2004 10:42:44 -0400 Date: Tue, 12 Oct 2004 14:42:00 -0000 From: Daniel Jacobowitz To: Michael Chastain Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa] Dwarf2 testsuite Message-ID: <20041012144242.GA17864@nevyn.them.org> Mail-Followup-To: Michael Chastain , gdb-patches@sources.redhat.com References: <20041008183500.GA6625@nevyn.them.org> <4166EE58.nailDYH15U42R@mindspring.com> <20041008202550.GA4140@nevyn.them.org> <416A0309.nail18911G85W@mindspring.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <416A0309.nail18911G85W@mindspring.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-10/txt/msg00209.txt.bz2 On Sun, Oct 10, 2004 at 11:50:33PM -0400, Michael Chastain wrote: > Okay, it works fine in my test bed with: > > gdb 6.2.1 and gdb HEAD > gcc 2, gcc 3, gcc 4pre > dwarf-2 and stabs+ (not that it makes any difference) > -feliminate-dwarf2-dups or not (ditto) > > drow> I'd prefer to leave the comments now that I've written them, for two > drow> reasons: > drow> (A) !#(*& it, I spent a lot of effort on those comments! > drow> (B) they make it easier to make a copy with only an incremental change > > Okay with me. > > Two nits: > > The copyright notice to Makefile.in. Grab from gdb.fortran/Makefile.in > if you like. (And yeah, the copyright notice in main.c makes me laugh > at my own stubbornness). > > Is file2.txt used at all? I could not find a reference to it. > > With those things fixed ... approved. Committed with those changes. Thanks! Next, I'll try to write a test for inter-cu... -- Daniel Jacobowitz