From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15057 invoked by alias); 8 Oct 2004 20:25:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14993 invoked from network); 8 Oct 2004 20:25:52 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 8 Oct 2004 20:25:52 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1CG1JG-0003EA-R5; Fri, 08 Oct 2004 16:25:51 -0400 Date: Fri, 08 Oct 2004 20:25:00 -0000 From: Daniel Jacobowitz To: Michael Chastain Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa] Dwarf2 testsuite Message-ID: <20041008202550.GA4140@nevyn.them.org> Mail-Followup-To: Michael Chastain , gdb-patches@sources.redhat.com References: <20041008183500.GA6625@nevyn.them.org> <4166EE58.nailDYH15U42R@mindspring.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4166EE58.nailDYH15U42R@mindspring.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-10/txt/msg00160.txt.bz2 On Fri, Oct 08, 2004 at 03:45:28PM -0400, Michael Chastain wrote: > Okay, I threw this in my in-queue and I'll reply on Sunday (estimated). Cool. Thank you. > Some random comments: > > . It's okay to have tests that execute on some systems and not others, > as long as gnu/hurd and gnu/linux are included. This is actually > covered in section 6, "platforms to support", in > http://www.fsf.org/prep/maintain/maintain.html Hmm, Hurd is ELF also, so that should be fine. > . Makefile.in needs a copyright notice. Actually all those little > subdirectories shouldn't even need configure/makefile stuff, > but I don't wanna get into that right now. OK. > . The self-documenting bit is cool, just leave a comment > "compile the file and run readelf -w to see what is going on". > In fact you might want to strip the comments from this file, > because when I go to debug something with a file like this, > I don't trust the comments in the file anyways. I'd prefer to leave the comments now that I've written them, for two reasons: (A) !#(*& it, I spent a lot of effort on those comments! (B) they make it easier to make a copy with only an incremental change > . We definitely need some infrastructure to return what the > debug format is, but you can just ignore that and do whatever > for now, as long as it doesn't totally blow up when I explicitly > test with "runtest /gdb:debug_flags=-gstabs+ -g2". It won't blow up. In fact, if GDB is working correctly, it will pass - if it doesn't, that's a bug. Mixed stabs and dwarf2 ought to work. -- Daniel Jacobowitz