From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8448 invoked by alias); 7 Oct 2004 17:15:54 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8434 invoked from network); 7 Oct 2004 17:15:52 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 7 Oct 2004 17:15:52 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1CFbrI-0002fb-AB; Thu, 07 Oct 2004 13:15:16 -0400 Date: Thu, 07 Oct 2004 17:15:00 -0000 From: Daniel Jacobowitz To: "Maciej W. Rozycki" Cc: gdb-patches@sources.redhat.com, Nigel Stephens , "Maciej W. Rozycki" Subject: Re: MIPS/Linux: Single-stepping running away Message-ID: <20041007171515.GA10186@nevyn.them.org> Mail-Followup-To: "Maciej W. Rozycki" , gdb-patches@sources.redhat.com, Nigel Stephens , "Maciej W. Rozycki" References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-10/txt/msg00132.txt.bz2 On Thu, Oct 07, 2004 at 06:12:10PM +0100, Maciej W. Rozycki wrote: > Hello, > > I've found two bugs in gdb that lead to single-stepping over branches > failing under specific conditions -- the code tests register numbers > instead of their values for a few variants of branches. Here is an > obvious fix. It applies against the head. > > 2004-10-07 Maciej W. Rozycki > > * mips-tdep.c (mips32_next_pc): Check the register's contents, > not its number for BLEZ/BLEZL and BGTZ/BGTZL. > > Please apply. I made the foolish mistake of mixing this fix into some larger MIPS unwinder changes many months ago, which I've never had time to disentangle. Sorry 'bout that. This patch is indeed obvious; I'll check it in for you. -- Daniel Jacobowitz