From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3431 invoked by alias); 6 Oct 2004 09:07:17 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3325 invoked from network); 6 Oct 2004 09:07:16 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 6 Oct 2004 09:07:16 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i9697GCb011845 for ; Wed, 6 Oct 2004 05:07:16 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i9697Br14522 for ; Wed, 6 Oct 2004 05:07:11 -0400 Received: from cygbert.vinschen.de (vpn50-13.rdu.redhat.com [172.16.50.13]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id i96979Vb024205 for ; Wed, 6 Oct 2004 05:07:10 -0400 Received: by cygbert.vinschen.de (Postfix, from userid 500) id 7B79E58092; Wed, 6 Oct 2004 11:08:09 +0200 (CEST) Date: Wed, 06 Oct 2004 09:07:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [PATCH]: SH 2a - Part 4: Begin using RETURN_VALUE Message-ID: <20041006090809.GE3744@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <20040909124701.GA7927@cygbert.vinschen.de> <16738.43902.850632.187540@localhost.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16738.43902.850632.187540@localhost.redhat.com> User-Agent: Mutt/1.4.2i X-SW-Source: 2004-10/txt/msg00108.txt.bz2 On Oct 5 10:11, Elena Zannoni wrote: > Corinna Vinschen writes: > > this is SH 2a patch 4. It does not introduce new functionality, but > > instead it converts sh-tdep.c to use RETURN_VALUE instead of > > STORE_RETURN_VALUE, EXTRACT_RETURN_VALUE, RETURN_VALUE_ON_STACK and > > USE_STRUCT_CONVENTION. > > OK Thanks, applied. > > What this patch does *not* do is this: I would love to rename the > > functions sh_default_store/extract_value and sh3e_sh4_store/extract_value > > to sh_store/extract_value_nofpu and sh_store/extract_value_fpu. > > This would decouple the sense of these functions from the cpu names, > > which is rather irritating and wrong anyway. If that's ok, I'd > > submit another patch which just performs the renaming. > > It wasn't wrong and irritating at the time it was introduced. Yes, that's apparently right. As I wrote, "I would love to...", because time has gone a bit over that naming scheme and I think, changing the names to reflect their usage in a more general way would help when reading the code in future. Is it ok to rename them? > > BEFORE AFTER > > Thanks for providing the test results. Are these with > sources.redhat.com sources? Or some internal only tree? What version > of gcc? So we have a good reference point. I used sources sources (erm...) to evaluate these results, exactly CVS HEAD from 2004-09-08. GCC was a 3.4 with SH2a patches applied. Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat, Inc.