From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25047 invoked by alias); 4 Oct 2004 15:42:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25038 invoked from network); 4 Oct 2004 15:42:38 -0000 Received: from unknown (HELO svr68.ehostpros.com) (67.15.48.48) by sourceware.org with SMTP; 4 Oct 2004 15:42:38 -0000 Received: from [61.11.18.135] (helo=pythagoras) by svr68.ehostpros.com with esmtpsa (TLSv1:RC4-MD5:128) (Exim 4.42) id 1CEUyw-00075E-DO; Mon, 04 Oct 2004 08:42:35 -0700 From: "Amit S. Kale" Organization: LinSysSoft Technologies Pvt Ltd To: Andrew Cagney Subject: Re: kgdb support for gdb Date: Mon, 04 Oct 2004 15:42:00 -0000 User-Agent: KMail/1.5 Cc: gdb-patches@sources.redhat.com References: <200410011314.33157.amitkale@linsyssoft.com> <416168C5.6010601@gnu.org> In-Reply-To: <416168C5.6010601@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200410042111.33306.amitkale@linsyssoft.com> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - svr68.ehostpros.com X-AntiAbuse: Original Domain - sources.redhat.com X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - linsyssoft.com X-Source: X-Source-Args: X-Source-Dir: X-SW-Source: 2004-10/txt/msg00051.txt.bz2 On Monday 04 Oct 2004 8:44 pm, Andrew Cagney wrote: > > Index: src/gdb/remote.c > > =================================================================== > > --- src.orig/gdb/remote.c 2004-09-25 01:21:18.000000000 +0530 > > +++ src/gdb/remote.c 2004-10-01 12:58:49.000000000 +0530 > > @@ -271,12 +271,13 @@ > > > > /* Default maximum number of characters in a packet body. Many > > remote stubs have a hardwired buffer size of 400 bytes > > - (c.f. BUFMAX in m68k-stub.c and i386-stub.c). BUFMAX-1 is used > > + (c.f. BUFMAX in m68k-stub.c and i386-stub.c). > > + BUFMAX is defined as 1024 in most kgdb stubs. BUFMAX-1 is used > > as the maximum packet-size to ensure that the packet and an extra > > NUL character can always fit in the buffer. This stops GDB > > trashing stubs that try to squeeze an extra NUL into what is > > already a full buffer (As of 1999-12-04 that was most stubs. */ > > - rs->remote_packet_size = 400 - 1; > > + rs->remote_packet_size = 1024 - 1; > > > > /* Should rs->sizeof_g_packet needs more space than the > > default, adjust the size accordingly. Remember that each byte is > > As the comment explains, the change is wrong. Can I suggest starting a > new thread on gdb@ explaining the underlying problem that you're trying > to fix here (however, can you also delay it a bit, gdb@'s currently > dominated by MI questions). No problem! I'll keep this in mind and bring this point up in the next round of discussions? I have to first work on the changes suggested by Mark K. -Amit