From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6932 invoked by alias); 3 Oct 2004 16:16:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6923 invoked from network); 3 Oct 2004 16:16:21 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 3 Oct 2004 16:16:21 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1CE925-00019a-Cv; Sun, 03 Oct 2004 12:16:21 -0400 Date: Sun, 03 Oct 2004 16:16:00 -0000 From: Daniel Jacobowitz To: Jim Blandy Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa/dwarf] Support for attributes pointing to a different CU Message-ID: <20041003161621.GB3234@nevyn.them.org> Mail-Followup-To: Jim Blandy , gdb-patches@sources.redhat.com References: <20040923045723.GA11871@nevyn.them.org> <20040924003412.GB10500@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-10/txt/msg00037.txt.bz2 On Wed, Sep 29, 2004 at 02:50:20PM -0500, Jim Blandy wrote: > > > @@ -4610,6 +4821,9 @@ read_subrange_type (struct die_info *die > > low = 1; > > } > > > > + /* FIXME: For variable sized arrays either of these could be > > + a variable rather than a constant value. We'll allow it, > > + but we don't know how to handle it. */ > > attr = dwarf2_attr (die, DW_AT_lower_bound, cu); > > if (attr) > > low = dwarf2_get_attr_constant_value (attr, 0); > > This should be committed separately. OK, done as below. -- Daniel Jacobowitz 2004-10-03 Daniel Jacobowitz * dwarf2read.c (read_subrange_type): Add comment for variable sized arrays. Index: dwarf2read.c =================================================================== RCS file: /cvs/src/src/gdb/dwarf2read.c,v retrieving revision 1.163 diff -u -p -r1.163 dwarf2read.c --- dwarf2read.c 21 Sep 2004 15:04:41 -0000 1.163 +++ dwarf2read.c 3 Oct 2004 16:14:23 -0000 @@ -4610,6 +4610,9 @@ read_subrange_type (struct die_info *die low = 1; } + /* FIXME: For variable sized arrays either of these could be + a variable rather than a constant value. We'll allow it, + but we don't know how to handle it. */ attr = dwarf2_attr (die, DW_AT_lower_bound, cu); if (attr) low = dwarf2_get_attr_constant_value (attr, 0);