From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 356 invoked by alias); 1 Oct 2004 18:25:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 345 invoked from network); 1 Oct 2004 18:25:22 -0000 Received: from unknown (HELO nile.gnat.com) (205.232.38.5) by sourceware.org with SMTP; 1 Oct 2004 18:25:22 -0000 Received: from localhost (localhost [127.0.0.1]) by nile.gnat.com (Postfix) with ESMTP id DA712F2D23; Fri, 1 Oct 2004 14:25:21 -0400 (EDT) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 18532-01-6; Fri, 1 Oct 2004 14:25:21 -0400 (EDT) Received: by nile.gnat.com (Postfix, from userid 1345) id 82B4AF2D27; Fri, 1 Oct 2004 14:25:21 -0400 (EDT) From: Paul Hilfinger To: cagney@gnu.org Cc: brobecker@gnat.com, jimb@redhat.com, gdb-patches@sources.redhat.com In-reply-to: <415D6817.50005@gnu.org> (message from Andrew Cagney on Fri, 01 Oct 2004 10:22:15 -0400) Subject: Re: [RFA]: Turn on initial Ada support in GDB References: <20040927103327.450A8F2C33@nile.gnat.com> <4159A662.2090407@gnu.org> <20040930073351.6BE79F2BA6@nile.gnat.com> <415CADC5.6050205@gnu.org> <20041001102419.78F74F2D17@nile.gnat.com> <415D6817.50005@gnu.org> Message-Id: <20041001182521.82B4AF2D27@nile.gnat.com> Date: Fri, 01 Oct 2004 18:25:00 -0000 X-Virus-Scanned: by amavisd-new at nile.gnat.com X-SW-Source: 2004-10/txt/msg00022.txt.bz2 X-Original-To: hilfingr@gnat.com Date: Fri, 01 Oct 2004 10:22:15 -0400 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040831 X-Accept-Language: en, en-us To: Paul Hilfinger Cc: brobecker@gnat.com Subject: Re: [RFA]: Turn on initial Ada support in GDB In-Reply-To: <20041001102419.78F74F2D17@nile.gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed X-Virus-Scanned: by amavisd-new at nile.gnat.com I wrote to Andrew: > Well, I can't commit the symtab.c changes until the Ada files are included, > due to use of ada_decode_symbol. Andrew responded: > Oops! That's a bug in that patch -> we're ment to dispatch language > specific stuff through the language vector. Inasmuch as the symtab.c patch has been approved (twice), I'm getting a little whipsawn here. I happen to agree with your sentiment, but could we pretty please get this Ada stuff in, after which I promise to look into the refactoring you have requested here? If you look at the existing code (even before the modifications I put in some time ago to add a necessary hook) there are specific tests in symtab.c for C++, C, Java, Objc. OK; this is a design bug, but let's just say that it is a TIC (Tenants in Common) sort of bug. Paul