From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9406 invoked by alias); 1 Oct 2004 10:41:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9225 invoked from network); 1 Oct 2004 10:41:35 -0000 Received: from unknown (HELO nile.gnat.com) (205.232.38.5) by sourceware.org with SMTP; 1 Oct 2004 10:41:35 -0000 Received: from localhost (localhost [127.0.0.1]) by nile.gnat.com (Postfix) with ESMTP id 1418DF2938; Fri, 1 Oct 2004 06:41:34 -0400 (EDT) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 24635-01-4; Fri, 1 Oct 2004 06:41:33 -0400 (EDT) Received: by nile.gnat.com (Postfix, from userid 1345) id BF232F2CA3; Fri, 1 Oct 2004 06:41:33 -0400 (EDT) From: Paul Hilfinger To: gdb-patches@sources.redhat.com Cc: brobecker@gnat.com, cagney@gnu.org In-reply-to: <415CADC5.6050205@gnu.org> (message from Andrew Cagney on Thu, 30 Sep 2004 21:07:17 -0400) Subject: Re: [RFA]: Turn on initial Ada support in GDB References: <20040927103327.450A8F2C33@nile.gnat.com> <4159A662.2090407@gnu.org> <20040930073351.6BE79F2BA6@nile.gnat.com> <415CADC5.6050205@gnu.org> Message-Id: <20041001104133.BF232F2CA3@nile.gnat.com> Date: Fri, 01 Oct 2004 10:41:00 -0000 X-Virus-Scanned: by amavisd-new at nile.gnat.com X-SW-Source: 2004-10/txt/msg00013.txt.bz2 Aside from the documentation patch and the previously posted (and approved) symtab.c patch, all that remains to give initial Ada support is the following Makefile.in patch. I will commit this tonight, as well, but first wanted to give time for comment/protest: building with Ada currently requires flex (I don't believe that lex has a guaranteed and blessed way of substituting input sources cleanly at arbitrary times). Flex is perhaps not a universal utility, and I wondered if I should also check in ada-lex.c (a practice we've discontinued for yacc), or should assume that folks who build from the CVS sources are expected to have flex. Paul Hilfinger 2004-09-30 Paul N. Hilfinger Turn on initial Ada support (mainly expression evaluation). * Makefile.in: (HFILES_NO_SRCDIR): Add ada-lang.h. (COMMON_OBS): Add ada-lang.o, ada-typeprint.o, ada-valprint.o. (YYOBJ): Add ada-exp.o. (SFILES): Remove ada-tasks.c. (rule .l.c): Generalize to not mention ada. (ada-lex.o): Remove (ada-lex.c is included by ada-exp.y). (ada-lang.o): Add dependencies on completer.h, gdb_obstack.h, hashtab.h. (ada-valprint.o): Add dependency on gdb_string.h. (ada-exp.o): Add dependency on gdb_string.h. Index: current-public.103/gdb/Makefile.in --- current-public.103/gdb/Makefile.in Fri, 01 Oct 2004 00:11:25 -0700 hilfingr +++ current-public.103(w)/gdb/Makefile.in Fri, 01 Oct 2004 00:23:17 -0700 hilfingr @@ -510,7 +510,7 @@ TARGET_FLAGS_TO_PASS = \ # Links made at configuration time should not be specified here, since # SFILES is used in building the distribution archive. -SFILES = ada-exp.y ada-lang.c ada-typeprint.c ada-valprint.c ada-tasks.c \ +SFILES = ada-exp.y ada-lang.c ada-typeprint.c ada-valprint.c \ ax-general.c ax-gdb.c \ bcache.c \ bfd-target.c \ @@ -847,7 +847,7 @@ HFILES_NO_SRCDIR = bcache.h buildsym.h c symfile.h symfile-mem.h stabsread.h target.h terminal.h typeprint.h \ xcoffsolib.h \ macrotab.h macroexp.h macroscope.h \ - c-lang.h f-lang.h \ + ada-lang.h c-lang.h f-lang.h \ jv-lang.h \ m2-lang.h p-lang.h \ complaints.h valprint.h \ @@ -908,7 +908,7 @@ COMMON_OBS = $(DEPFILES) $(YYOBJ) \ dbxread.o coffread.o coff-pe-read.o elfread.o \ dwarfread.o dwarf2read.o mipsread.o stabsread.o corefile.o \ dwarf2expr.o dwarf2loc.o dwarf2-frame.o \ - c-lang.o f-lang.o objc-lang.o \ + ada-lang.o c-lang.o f-lang.o objc-lang.o \ ui-out.o cli-out.o \ varobj.o wrapper.o \ jv-lang.o jv-valprint.o jv-typeprint.o \ @@ -916,8 +916,8 @@ COMMON_OBS = $(DEPFILES) $(YYOBJ) \ scm-exp.o scm-lang.o scm-valprint.o \ sentinel-frame.o \ complaints.o typeprint.o \ - c-typeprint.o f-typeprint.o m2-typeprint.o \ - c-valprint.o cp-valprint.o f-valprint.o m2-valprint.o \ + ada-typeprint.o c-typeprint.o f-typeprint.o m2-typeprint.o \ + ada-valprint.o c-valprint.o cp-valprint.o f-valprint.o m2-valprint.o \ nlmread.o serial.o mdebugread.o top.o utils.o \ ui-file.o \ user-regs.o \ @@ -941,6 +941,7 @@ YYFILES = c-exp.c \ f-exp.c m2-exp.c p-exp.c YYOBJ = c-exp.o \ objc-exp.o \ + ada-exp.o \ jv-exp.o \ f-exp.o m2-exp.o p-exp.o @@ -1581,7 +1582,7 @@ po/$(PACKAGE).pot: force echo $(FLEX) -Isit $< ">" $@; \ $(FLEX) -Isit $< > $@; \ elif [ ! -f $@ -a ! -f $< ]; then \ - echo "ada-lex.c missing and flex not available."; \ + echo "$< missing and flex not available."; \ false; \ elif [ ! -f $@ ]; then \ echo "Warning: $*.c older than $*.l and flex not available."; \