From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24633 invoked by alias); 23 Sep 2004 23:34:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24625 invoked from network); 23 Sep 2004 23:34:44 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sourceware.org with SMTP; 23 Sep 2004 23:34:44 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id F3BB547D95; Thu, 23 Sep 2004 16:34:43 -0700 (PDT) Date: Thu, 23 Sep 2004 23:34:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: [RFA/PATCH/mips16] Remove dead code in mips_insn16_frame_cache Message-ID: <20040923233443.GJ968@gnat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="W/nzBZO5zC0uMSeA" Content-Disposition: inline User-Agent: Mutt/1.4i X-SW-Source: 2004-09/txt/msg00388.txt.bz2 --W/nzBZO5zC0uMSeA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 462 I think this is obvious, but just in case, I'm posting this as a semi-rfa before I do something wrong. 2004-09-23 Joel Brobecker * mips-tdep.c (mips_insn16_frame_cache): Remove dead code or conditions that will always be true. Untested. I'll make sure it compiles before I commit. OK to apply anyway? The next step is to mimick the mips32 changes to mips16, so that they both update the frame cache. Thanks, -- Joel --W/nzBZO5zC0uMSeA Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="mips16.diff" Content-length: 1708 Index: mips-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/mips-tdep.c,v retrieving revision 1.324 diff -u -p -r1.324 mips-tdep.c --- mips-tdep.c 16 Sep 2004 00:35:55 -0000 1.324 +++ mips-tdep.c 23 Sep 2004 23:23:16 -0000 @@ -1850,24 +1850,14 @@ mips_insn16_frame_cache (struct frame_in /* If the address is odd, assume this is MIPS16 code. */ addr = PROC_LOW_ADDR (proc_desc); - mips16 = pc_is_mips16 (addr); /* Scan through this function's instructions preceding the current PC, and look for those that save registers. */ while (addr < frame_pc_unwind (next_frame)) { - if (mips16) - { - mips16_decode_reg_save (mips16_fetch_instruction (addr), - &gen_save_found); - addr += MIPS16_INSTLEN; - } - else - { - mips32_decode_reg_save (mips32_fetch_instruction (addr), - &gen_save_found, &float_save_found); - addr += MIPS_INSTLEN; - } + mips16_decode_reg_save (mips16_fetch_instruction (addr), + &gen_save_found); + addr += MIPS16_INSTLEN; } gen_mask = gen_save_found; float_mask = float_save_found; @@ -1891,7 +1881,6 @@ mips_insn16_frame_cache (struct frame_in order of that normally used by gcc. Therefore, we have to fetch the first instruction of the function, and if it's an entry instruction that saves $s0 or $s1, correct their saved addresses. */ - if (pc_is_mips16 (PROC_LOW_ADDR (proc_desc))) { ULONGEST inst = mips16_fetch_instruction (PROC_LOW_ADDR (proc_desc)); if ((inst & 0xf81f) == 0xe809 && (inst & 0x700) != 0x700) --W/nzBZO5zC0uMSeA--