From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8239 invoked by alias); 23 Sep 2004 20:58:32 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8192 invoked from network); 23 Sep 2004 20:58:29 -0000 Received: from unknown (HELO walton.sibelius.xs4all.nl) (82.92.89.47) by sourceware.org with SMTP; 23 Sep 2004 20:58:29 -0000 Received: from elgar.sibelius.xs4all.nl (elgar.sibelius.xs4all.nl [192.168.0.2]) by walton.sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id i8NKwOkW002272; Thu, 23 Sep 2004 22:58:24 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (localhost [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6) with ESMTP id i8NKwIjL009189; Thu, 23 Sep 2004 22:58:18 +0200 (CEST) (envelope-from kettenis@elgar.sibelius.xs4all.nl) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6/Submit) id i8NKwHg4009186; Thu, 23 Sep 2004 22:58:17 +0200 (CEST) Date: Thu, 23 Sep 2004 20:58:00 -0000 Message-Id: <200409232058.i8NKwHg4009186@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: me@cgf.cx CC: gdb-patches@sources.redhat.com In-reply-to: <20040923050534.GA11936@trixie.casa.cgf.cx> (message from Christopher Faylor on Thu, 23 Sep 2004 01:05:34 -0400) Subject: Re: [RFC] Suggested ways to remove the need for xm-go32.h References: <01c49d82$Blat.v2.2.2$23875ec0@zahav.net.il> <20040923050534.GA11936@trixie.casa.cgf.cx> X-SW-Source: 2004-09/txt/msg00384.txt.bz2 Date: Thu, 23 Sep 2004 01:05:34 -0400 From: Christopher Faylor On Sat, Sep 18, 2004 at 04:18:31PM +0300, Eli Zaretskii wrote: >Here's how I propose to deal with each one of these: > >1. fopen-bin.h: I suggest to modify the default definitions of the > FOPEN_* macros on defs.h to the ANSI/ISO-compatible "rb", "wb", > etc. strings that include the "b" modifier. Since we already > require ISO C compliance from all the ports, such a default must > DTRT. Once the defaults are changed, there should be no need to > use fopen-bin.h neither in the DJGPP nor in the Cygwin port. I'd be happy to see this but I see that later in the thread that we seem to be converging on a wrapper function. I still favour the wrapper function, since that's more robust, but I wouldn't really object if we'd use exactly the same configure magic as BFD does. Note that that imposes a burden on the maintainers of DOS-ish systems to keep it in sync with BFD. >4. DIRNAME_SEPARATOR: The DOS-specific definition can be put either > in defs.h or local to the only file that uses it (source.c). This could be determined at configure time couldn't it? You could play with the path to see if a colon or semicolon does the desired thing and then set it appropriately via config.in. Please note that DIRNAME_SEPARATOR is only used in GDB. Preferably it would be the same on all hosts, although it makes sense to follow the convention of the host platform if there is one. That's why we have ':' on POSIX-ish systems. The most important reasone why it's something different on DOS-ish systems, is that ':' is to specify drive letters and therefore useless as a sepatator. Makes me wonder why cygwin uses ':'. Mark