From: Daniel Jacobowitz <drow@false.org>
To: Jim Blandy <jimb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/intercu] Preserve DIE types
Date: Tue, 21 Sep 2004 12:51:00 -0000 [thread overview]
Message-ID: <20040921125116.GA9804@nevyn.them.org> (raw)
In-Reply-To: <vt2oek09m0l.fsf@zenia.home>
On Tue, Sep 21, 2004 at 01:25:14AM -0500, Jim Blandy wrote:
>
> Daniel Jacobowitz <drow@false.org> writes:
> > The only solution I could find was to cache this information, specifically
> > the DIE -> type mapping.
>
> I think that's the only correct thing to do.
>
> > Tested on i686-pc-linux-gnu. OK?
>
> It looks fine. Just one question: in set_die_type, why do you check
> whether cu->per_cu is NULL? Under what circumstances would we be
> associating types to dies in a compilation unit that is not considered
> "read in"?
cu->per_cu != NULL is the flag which indicates that we've seen an
inter-compilation-unit reference. If we haven't, then we'll read in
this compilation unit but discard it completely when we're done with
it.
--
Daniel Jacobowitz
next prev parent reply other threads:[~2004-09-21 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-21 2:31 Daniel Jacobowitz
2004-09-21 6:26 ` Jim Blandy
2004-09-21 12:51 ` Daniel Jacobowitz [this message]
2004-09-21 15:03 ` Jim Blandy
2004-09-21 15:04 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040921125116.GA9804@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox