Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Paul Hilfinger <hilfingr@gnat.com>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit] Move hex_string et.al. to defs.h / utils.c
Date: Sat, 11 Sep 2004 19:43:00 -0000	[thread overview]
Message-ID: <20040911194329.1B29DF2E3A@nile.gnat.com> (raw)


> Somehow some some #include "language.h" were lost with PaulH's recent 
> *_string_custom cleanup.

> Rather than add lots of those includes, I moved the hex_string and 
> hex_string_custom functions to utils.c, and the corresponding 
> declaration to defs.h.  I also took the oportunity to improve the code a 
> little switching it to get_cell().

Andrew,

Actually, the #includes were dropped deliberately, and you've done the piece
what was SUPPOSED to happen and somehow got dropped: moving the decls to 
defs.h and defns to utils.c.  Thanks.  I must be careful not to overlook
mere warnings (speaking of which, it would be a nice goal to remove all
warnings from GDB compilations, lest they distract).  

> To answer your question about my thoughts on get_cell - I think it sux 
> less than the old code's local static buffer :-)

It does make one long for fast GC, does it not?  Or perhaps something 
region-based, where the region gets deallocated at, say, a point in the
top-level command loop.

Paul


             reply	other threads:[~2004-09-11 19:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-11 19:43 Paul Hilfinger [this message]
2004-09-12 15:45 ` Andrew Cagney
  -- strict thread matches above, loose matches on Subject: below --
2004-09-11 15:04 Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040911194329.1B29DF2E3A@nile.gnat.com \
    --to=hilfingr@gnat.com \
    --cc=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox