From: Daniel Jacobowitz <drow@false.org>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa] Gut signals.exp
Date: Tue, 07 Sep 2004 16:28:00 -0000 [thread overview]
Message-ID: <20040907162831.GA7505@nevyn.them.org> (raw)
In-Reply-To: <413DC19E.2030209@gnu.org>
On Tue, Sep 07, 2004 at 10:11:42AM -0400, Andrew Cagney wrote:
> The only interesting bit [well I think] is that I'm also removing
> several xfails. The xfailed test (it should have been a kfail) is
> checking that GDB remembers that it was single-stepping, so that when a
> signal handler breakpoint is hit and then continued, GDB resumes the
> earlier single-step task. Making this work would involve a stack of
> outstanding commands and would require a very good UI design.
> Consequently, I think the feature & test can be dropped until someone is
> motivated to design / implement it.
I'd like to have a record of this, since I've wanted it several times.
Would you please file a PR, if there isn't one already? Beyond that I
don't care if it's tested. Tests for unimplemented features don't do
much good.
> - # In running to func2, the 2rd alarm call will have been set
> - # up, let it be delivered.
> -
> - # This doesn't work correctly on platforms with hardware single
> - # step...
> -
> - sleep 2
> -
> - setup_kfail "i*86-*-*" gdb/1738
> - setup_kfail "x86_64-*-*" gdb/1738
> - setup_kfail "rs6000-*-*" gdb/1738
> - setup_kfail "powerpc-*-*" gdb/1738
> - setup_kfail "sparc-*-*" gdb/1738
> - gdb_test "continue" "Breakpoint.*handler.*" \
> - "continue to handler for 3rd alarm call"
> -
> - setup_kfail "i*86-*-*" gdb/1738
> - setup_kfail "x86_64-*-*" gdb/1738
> - setup_kfail "rs6000-*-*" gdb/1738
> - setup_kfail "powerpc-*-*" gdb/1738
> - setup_kfail "sparc-*-*" gdb/1738
> - gdb_test "backtrace" \
> - "#0 handler.*#1.*signal handler called.*#2 func2.*#3.*main.*" \
> - "backtrace for 3rd alarm"
Ignoring that I obviously got the analysis and the kfails wrong, did
the Linux kernel patch you mentioned fix this test in the previous
version of signals.exp? If not, is there another failing test that you
are confident is the same problem?
I'm guessing the former but I can't check myself.
--
Daniel Jacobowitz
next prev parent reply other threads:[~2004-09-07 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-24 15:20 Andrew Cagney
2004-08-24 15:51 ` Michael Chastain
2004-09-07 14:12 ` Andrew Cagney
2004-09-07 14:41 ` Michael Chastain
2004-09-07 16:28 ` Daniel Jacobowitz [this message]
2004-09-07 20:07 ` Andrew Cagney
2004-09-07 23:26 ` Daniel Jacobowitz
2004-09-08 22:02 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040907162831.GA7505@nevyn.them.org \
--to=drow@false.org \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox