From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11564 invoked by alias); 30 Aug 2004 18:18:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11550 invoked from network); 30 Aug 2004 18:18:30 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sourceware.org with SMTP; 30 Aug 2004 18:18:30 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 78B7047D91; Mon, 30 Aug 2004 11:18:29 -0700 (PDT) Date: Mon, 30 Aug 2004 18:18:00 -0000 From: Joel Brobecker To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/RFC] fix problems with unwinder on mips-irix Message-ID: <20040830181829.GC969@gnat.com> References: <20040723011059.GI20596@gnat.com> <410994BD.5040506@gnu.org> <20040803044358.GA18163@gnat.com> <411039F3.1020102@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <411039F3.1020102@gnu.org> User-Agent: Mutt/1.4i X-SW-Source: 2004-08/txt/msg00772.txt.bz2 Andrew, I would like to fix the following issue: > >>>>>2004-07-22 Joel Brobecker > >>>>> > >>>>> * mips-tdep.c (mips_mdebug_frame_cache): Minor reformatting. > >>>>> (set_saved_reg_info): New function. > >>>>> (mips32_heuristic_proc_desc): Compute the procedure descriptor > >>>>> PROC_REG_OFFSET. > >>>>> > >> > >>> > >>>It's time to cut our losses and split the mdebug and heuristic cases. > >>>Lets work through this change after I've done that. But you want a "major overhaul" of the mips unwinder as a precondition to fixing the problem at hand. Could you explain a bit more what overhaul you are interested in? I don't see what needs to be done. In particular, you said: > Two key things to know: > > - with three unwinders handling three different cases previously handled > by one, there's a lot of dead code paths. For instance, > mips32_heuristic_proc_desc is now only called by mips_insn32_frame_cache > and hence can be inlined there, making it possible for your problem to > be solved more locally. mips32_heuristic_proc_desc is called by heuristic_proc_desc. (And frankly I find inlining often counter productive, as we end up with giant function just as we did with decode_line_1). Thanks, -- Joel