From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26471 invoked by alias); 27 Aug 2004 13:39:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26438 invoked from network); 27 Aug 2004 13:39:43 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sourceware.org with SMTP; 27 Aug 2004 13:39:43 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id D8D2D47D91; Fri, 27 Aug 2004 06:39:45 -0700 (PDT) Date: Fri, 27 Aug 2004 13:39:00 -0000 From: Joel Brobecker To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Enhance GDB to break inside DSO init code Message-ID: <20040827133945.GC1829@gnat.com> References: <20040723202447.GM20596@gnat.com> <20040824164507.11b04f11@saguaro> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040824164507.11b04f11@saguaro> User-Agent: Mutt/1.4i X-SW-Source: 2004-08/txt/msg00729.txt.bz2 Hello Kevin, > Do you have access to a Solaris box? If so, could you test for > regressions there as well? That's a good idea. So I tested the patch on sparc-solaris2.8 as well, without any regression. > If all goes well, I have no objection to this patch going in. (Consider > it approved unless someone else says otherwise.) I didn't see any objection, so I checked the patch in. Thank you for the review! > > 2004-07-23 Joel Brobecker > > > > * procfs.c (dbx_link_bpt_addr): New static global variable. > > (dbx_link_shadow_contents): New static global variable. > > (procfs_wait, case ): Handle syssgi events. > > (procfs_wait, case ): Remove the __dbx_link brekapoint > > if we just hit it. > > (procfs_init_inferior): Enable syssgi() syscall trace if appropriate. > > Reset dbx_link_bpt_addr as the address of __dbx_link() may change > > from run to run. > > (procfs_create_inferior): Remove syssgi syscall-exit notifications > > after the inferior has been forked. > > (remove_dbx_link_breakpoint): New function. > > (dbx_link_addr): New function. > > (insert_dbx_link_bpt_in_file): New function. > > (insert_dbx_link_bpt_in_region): New function. > > (insert_dbx_link_breakpoint): New function. > > (proc_trace_syscalls_1): New function, extracted from > > proc_trace_syscalls. > > (proc_trace_syscalls): Replace extract code by call to > > proc_trace_syscalls_1. > > * solib-irix.c (disable_break): Remove stop_pc assertion, as it > > is no longer valid. > > > > Tested on mips-irix, no regression. OK to commit? -- Joel