From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8637 invoked by alias); 26 Aug 2004 09:40:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8609 invoked from network); 26 Aug 2004 09:40:03 -0000 Received: from unknown (HELO server7.nfra.nl) (192.87.1.57) by sourceware.org with SMTP; 26 Aug 2004 09:40:03 -0000 Received: from juw15.nfra.nl [10.87.8.15] by server7.nfra.nl; Thu, 26 Aug 2004 11:40:15 +0200 Received: from juw15.nfra.nl (localhost [127.0.0.1]) by juw15.nfra.nl (8.12.2+Sun/8.11.1) with ESMTP id i7Q9cfCu000023; Thu, 26 Aug 2004 11:38:41 +0200 (CEST) Received: (from kettenis@localhost) by juw15.nfra.nl (8.12.2+Sun/8.12.2/Submit) id i7Q9ceac000020; Thu, 26 Aug 2004 11:38:40 +0200 (CEST) Date: Thu, 26 Aug 2004 09:40:00 -0000 Message-Id: <200408260938.i7Q9ceac000020@juw15.nfra.nl> From: Mark Kettenis To: jimb@redhat.com CC: cagney@gnu.org, gdb-patches@sources.redhat.com In-reply-to: (message from Jim Blandy on 25 Aug 2004 00:07:07 -0500) Subject: Re: RFA: Support libthread_db xregs interface References: <412A55E8.3060100@gnu.org> X-SW-Source: 2004-08/txt/msg00704.txt.bz2 Sender: jimb@zenia.home Cc: gdb-patches@sources.redhat.com From: Jim Blandy Date: 25 Aug 2004 00:07:07 -0500 Andrew Cagney writes: > > + v:=:const struct regset *:xregs_regset:::0 > > Mark's regset change added both the "regset.h" object and the > regset_from_core_section architecture method. They, together, replace > the old *-nat.c:fill_regset et.al. calls. > > Can we implement the equivalent here for ptrace/thread-db? Not sure what you mean. This change lets a gdbarch object specify a regset which the libthread_db support code will then use to read and write additional registers beyond those covered by gregset_t and fpregset_t. So this change does provide a regset.h-style regset for libthread_db. That's what you're looking for, right? I'm not sure, but I presume Andrew is asking you to implement a regset_from_xxx function for use by ptrace/thread-db, instead of explicitly adding the xregset to the architecture vector. Your current patch leaves the supply_gregset() and supply_fpregset() calls as they are. That's fine for now, but in the long run they'll have to be replaced with regset stuff too. By using a regset_from_xxx function we only need a single entry in the architecture vector, instead of three (or even more). > > + v:=:int:xregs_size:::0 > > + v:=:const char *:xregs_name:::0 > > I gather these were fields in the original xreg_desc object but are > missing from the "regset"? Should these, instead be added to the > regset, or a new object extending regset created? I was wondering about that, too. It'd certainly be neater. Mark, what's your take on this? Fine by me. The name is certainly useful for printing messages in the core case too. The size argument might be useful too, but it should probably be optional. There is no use to create an object extending the regset. These two should just go in the exitsting regset. Mark