From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18830 invoked by alias); 18 Aug 2004 19:39:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18817 invoked from network); 18 Aug 2004 19:39:53 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 18 Aug 2004 19:39:53 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1BxWHo-0007Co-Hz; Wed, 18 Aug 2004 15:39:52 -0400 Date: Wed, 18 Aug 2004 19:39:00 -0000 From: Daniel Jacobowitz To: Jeff Johnston Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA]: Fix for pending breakpoints in manually loaded/unloaded shlibs Message-ID: <20040818193952.GA27639@nevyn.them.org> Mail-Followup-To: Jeff Johnston , gdb-patches@sources.redhat.com References: <41191D71.60204@redhat.com> <20040811171203.GA4152@nevyn.them.org> <411A7D97.50104@redhat.com> <20040818135621.GA26257@nevyn.them.org> <4123AC6E.8000300@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4123AC6E.8000300@redhat.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-08/txt/msg00565.txt.bz2 On Wed, Aug 18, 2004 at 03:22:22PM -0400, Jeff Johnston wrote: > Daniel Jacobowitz wrote: > >On Wed, Aug 11, 2004 at 04:12:07PM -0400, Jeff Johnston wrote: > >>+ if (so_name > >>+ && !strcmp (so_name, solib->so_name)) > >>+ { > >>+ b->enable_state = bp_shlib_disabled; > >>+ /* At this point, we cannot rely on remove_breakpoint > >>+ succeeding so we must mark the breakpoint as not inserted > >>+ to prevent future errors occurring in remove_breakpoints. */ > >>+ b->loc->inserted = 0; > >>+ if (!disabled_shlib_breaks) > >>+ { > >>+ target_terminal_ours_for_output (); > >>+ warning ("Temporarily disabling unloaded shared library > >>breakpoints:"); > >>+ } > >>+ disabled_shlib_breaks = 1; > >>+ warning ("breakpoint #%d ", b->number); > > > > > >I think you're missing a space after the colon, in the first warning. > >Also, this use of multiple warning() statements is neither i18n > >friendly nor MI/GUI friendly - you may get a separate dialog box for > >each. I believe other places do this with sprintf; still not 100% i18n > >friendly, but avoids the MI/GUI problems. I can't find an example > >offhand. > > > > What you do want to see so I don't waste my time on this. As you already > know, this routine was copied from the routine which disables shared > library breakpoints in breakpoint.c. Is it sufficient to just issue the > warning that I am temporarily disabling unloaded shared library breakpoints > and not spell out each breakpoint in turn? I can see this as really > annoying and pointless to an end-user if there are hundreds or thousands of > breakpoints. That's a good idea. How about this? target_terminal_ours_for_output (); warning ("Temporarily disabling breakpoints for unloaded shared library \"%s\", so_name); -- Daniel Jacobowitz