Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFC] s/UINT_MAX/GDB_UINT_MAX/ ?
Date: Thu, 12 Aug 2004 01:22:00 -0000	[thread overview]
Message-ID: <20040812012245.GA21493@nevyn.them.org> (raw)
In-Reply-To: <20040811224640.GM25562@gnat.com>

On Wed, Aug 11, 2004 at 03:46:40PM -0700, Joel Brobecker wrote:
> This is the last entity in config/powerpc/xm-aix4.h. The comment says:
> 
> /* UINT_MAX is defined in <sys/limits.h> as a decimal constant (4294967295)
>    which is too large to fit in a signed int when it is parsed by the
>    compiler, so it issues a diagnostic.  Just undef it here so that we
>    use gdb's version in defs.h */
> #undef UINT_MAX
> 
> So we have a collision between the macro defined by GDB and the macro
> defined by the system. For recent enough versions of AIX, I don't think
> the values are different, so we could look the other way and just remove
> the #undef, and all things should work. But we still have this collision
> and I think we should fix it.
> 
> So I suggest we do an all-source rename of UINT_MAX et al to GDB_UINT_MAX,
> or something like this. Unless the collision was expected (ie we want to
> pick the system value when defined)?

The latter is correct.  Take a look at the definition, in defs.h.

That's a buggy system... if you want to support it, we should detect it
in autoconf.  Otherwise, I doubt we'll really miss the #undef.

-- 
Daniel Jacobowitz


  reply	other threads:[~2004-08-12  1:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-11 22:47 Joel Brobecker
2004-08-12  1:22 ` Daniel Jacobowitz [this message]
2004-08-12  1:26 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040812012245.GA21493@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox