From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15519 invoked by alias); 9 Aug 2004 15:12:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15503 invoked from network); 9 Aug 2004 15:12:22 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.77.109) by sourceware.org with SMTP; 9 Aug 2004 15:12:22 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i79FCKZt000399; Mon, 9 Aug 2004 17:12:20 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i79FCKmT000746; Mon, 9 Aug 2004 17:12:20 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i79FCJfd000743; Mon, 9 Aug 2004 17:12:19 +0200 (CEST) Date: Mon, 09 Aug 2004 15:12:00 -0000 Message-Id: <200408091512.i79FCJfd000743@elgar.kettenis.dyndns.org> From: Mark Kettenis To: cagney@gnu.org CC: gdb-patches@sources.redhat.com In-reply-to: <41169A0A.1020508@gnu.org> (message from Andrew Cagney on Sun, 08 Aug 2004 17:24:26 -0400) Subject: Re: [commit] Add BE/LE floating-point type & format tables References: <4116617A.8010601@gnu.org> <200408081951.i78JpTxK005673@elgar.kettenis.dyndns.org> <41169A0A.1020508@gnu.org> X-SW-Source: 2004-08/txt/msg00311.txt.bz2 Date: Sun, 08 Aug 2004 17:24:26 -0400 From: Andrew Cagney My original post gave one example, here's another: static struct type * mips_float_register_type (void) { if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG) return builtin_type_ieee_single_big; else return builtin_type_ieee_single_little; } Is all over the place. This: builtin_type_ieee_single[gdbarch_byte_order (gdbarch)] is shorter and correct. Ah OK. But is this going to get used for some other target than MIPS? It seems to me that you're introducing a lot of machinery just to make life a bit easier there. Oh, and your code really needs to do some bounds checking too, so I really doubt whether it is much simpler. > Anyway, could we rename floatformat_ia64_quad to > floatformat_ieee_quad. There are quite a few systems out there that > use or will be using the same format, and I believe i will be in a new > revision of the official IEEE standard for it. > local to gdb? Whatever. Mark