From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6344 invoked by alias); 9 Aug 2004 18:23:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6334 invoked from network); 9 Aug 2004 18:23:40 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 9 Aug 2004 18:23:40 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i79INee1018112 for ; Mon, 9 Aug 2004 14:23:40 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i79INea19273 for ; Mon, 9 Aug 2004 14:23:40 -0400 Received: from localhost.localdomain (vpn50-22.rdu.redhat.com [172.16.50.22]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id i79INegU003840 for ; Mon, 9 Aug 2004 14:23:40 -0400 Received: from saguaro (saguaro.lan [192.168.64.2]) by localhost.localdomain (8.12.11/8.12.10) with SMTP id i79INYPB003928 for ; Mon, 9 Aug 2004 11:23:34 -0700 Date: Mon, 09 Aug 2004 18:23:00 -0000 From: Kevin Buettner To: gdb-patches@sources.redhat.com Subject: Re: [RFC/AIX] xm-aix4.h - get rid of #undef fd_set & select #include Message-Id: <20040809112334.23b3d95f@saguaro> In-Reply-To: <20040808042601.GA24160@gnat.com> References: <20040808042601.GA24160@gnat.com> Organization: Red Hat Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2004-08/txt/msg00324.txt.bz2 On Sat, 7 Aug 2004 21:26:01 -0700 Joel Brobecker wrote: > config/xm-aix4.h contains the following definitions: > > | /* The following text is taken from config/rs6000.mh: > | * # The IBM version of /usr/include/rpc/rpc.h has a bug -- it says > | * # `extern fd_set svc_fdset;' without ever defining the type fd_set. > | * # Unfortunately this occurs in the vx-share code, which is not configured > | * # like the rest of GDB (e.g. it doesn't include "defs.h"). > | * # We circumvent this bug by #define-ing fd_set here, but undefining it in > | * # the xm-rs6000.h file before ordinary modules try to use it. FIXME, IBM! > | * MH_CFLAGS='-Dfd_set=int' > | * So, here we do the undefine...which has to occur before we include > | * below. > | */ > | #undef fd_set > | > | #include > > On our systems (AIX 4.3.2 and 5.1), this type is defined in time.h > > typedef struct > #ifdef _ALL_SOURCE > fd_set > #endif /* _ALL_SOURCE */ > { > long fds_bits[__NUM_ENTRIES]; /* bitmask for open file descriptors */ > } fd_set; > > I couldn't find config/rs6000.mh, nor the original comment. So I wonder > if we wouldn't be able to delete these two. > > I can give it a try, but would I miss something? I'm all in favor of giving it a try. I suspect that the the above was intended as a workaround for a much older version of AIX. (FWIW, I can't find the original comment either, but the xm-aix4.h comment and associated hackery was added in 1996.) Kevin