From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28380 invoked by alias); 8 Aug 2004 15:02:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28371 invoked from network); 8 Aug 2004 15:02:57 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.77.109) by sourceware.org with SMTP; 8 Aug 2004 15:02:57 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i78F2moa003581; Sun, 8 Aug 2004 17:02:48 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i78F2mKv000368; Sun, 8 Aug 2004 17:02:48 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i78F2m2Y000365; Sun, 8 Aug 2004 17:02:48 +0200 (CEST) Date: Sun, 08 Aug 2004 15:02:00 -0000 Message-Id: <200408081502.i78F2m2Y000365@elgar.kettenis.dyndns.org> From: Mark Kettenis To: cagney@gnu.org CC: gdb-patches@sources.redhat.com In-reply-to: <41163971.4070203@gnu.org> (message from Andrew Cagney on Sun, 08 Aug 2004 10:32:17 -0400) Subject: Re: [PATCH] Undeprecate GNU/Hurd References: <200408081417.i78EHf2r022405@elgar.kettenis.dyndns.org> <41163971.4070203@gnu.org> X-SW-Source: 2004-08/txt/msg00256.txt.bz2 Date: Sun, 08 Aug 2004 10:32:17 -0400 From: Andrew Cagney > @@ -268,15 +266,15 @@ gnu_store_registers (int regno) > proc_debug (thread, "storing all registers"); > > for (i = 0; i < I386_NUM_GREGS; i++) > - if (deprecated_register_valid[i]) > - fill (state, i); > + if (regcache_valid_p (regcache, i)) > + regcache_raw_supply (regcache, i, REG_ADDR (state, i)); > } > else Should this, and a few others, be ``collect''? Supplying an already valid register doesn't seem logical :-) Ouch. Thanks for spotting this one. Fixed by the attached patch. There is one instance where regcache_raw_supply is correct in that function. Index: ChangeLog from Mark Kettenis * i386gnu-nat.c (gnu_store_registers): Use regcache_raw_collect instead of regcache_raw_supply when storing the registers. Index: i386gnu-nat.c =================================================================== RCS file: /cvs/src/src/gdb/i386gnu-nat.c,v retrieving revision 1.20 diff -u -p -r1.20 i386gnu-nat.c --- i386gnu-nat.c 8 Aug 2004 12:50:37 -0000 1.20 +++ i386gnu-nat.c 8 Aug 2004 14:59:47 -0000 @@ -267,14 +267,14 @@ gnu_store_registers (int regno) for (i = 0; i < I386_NUM_GREGS; i++) if (regcache_valid_p (regcache, i)) - regcache_raw_supply (regcache, i, REG_ADDR (state, i)); + regcache_raw_collect (regcache, i, REG_ADDR (state, i)); } else { proc_debug (thread, "storing register %s", REGISTER_NAME (regno)); gdb_assert (regcache_valid_p (regcache, regno)); - regcache_raw_supply (regcache, regno, REG_ADDR (state, regno)); + regcache_craw_collect (regcache, regno, REG_ADDR (state, regno)); } /* Restore the T bit. */