From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10452 invoked by alias); 8 Aug 2004 11:08:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10444 invoked from network); 8 Aug 2004 11:08:21 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.77.109) by sourceware.org with SMTP; 8 Aug 2004 11:08:21 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i78B8Coa003197; Sun, 8 Aug 2004 13:08:12 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i78B8DSP009365; Sun, 8 Aug 2004 13:08:13 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i78B8Cpk009362; Sun, 8 Aug 2004 13:08:12 +0200 (CEST) Date: Sun, 08 Aug 2004 11:08:00 -0000 Message-Id: <200408081108.i78B8Cpk009362@elgar.kettenis.dyndns.org> From: Mark Kettenis To: mec.gnu@mindspring.com CC: eliz@gnu.org, gdb-patches@sources.redhat.com, cagney@gnu.org In-reply-to: <4115FF44.nail59F11C8I0@mindspring.com> (message from Michael Chastain on Sun, 08 Aug 2004 06:24:04 -0400) Subject: Re: [PATCH] Improve i386 prologue analyzer References: <200408012158.i71LwpRw033840@elgar.kettenis.dyndns.org> <3405-Mon02Aug2004070159+0300-eliz@gnu.org> <410EAFBB.5080102@gnu.org> <2914-Tue03Aug2004065313+0300-eliz@gnu.org> <200408061933.i76JX3HJ008032@elgar.kettenis.dyndns.org> <4113EA3B.3000900@gnu.org> <2914-Sat07Aug2004183455+0300-eliz@gnu.org> <41150161.3000306@gnu.org> <41155A83.nail9VC11PTRT@mindspring.com> <7704-Sun08Aug2004065437+0300-eliz@gnu.org> <4115FF44.nail59F11C8I0@mindspring.com> X-SW-Source: 2004-08/txt/msg00243.txt.bz2 Date: Sun, 08 Aug 2004 06:24:04 -0400 Sender: mec.gnu@mindspring.com eliz> If so, could you please explain why you think it needs any more eliz> ``marinating'' in HEAD? It's a new design. Yeah, it's a pretty invasive change. It not only affects the unwinder, but also prologue skipping in order to determine the first line of real code for a function. And this feature interacts with many different external variations. For example, I haven't seen anyone test it with gcc 2. I see no changes in the testsuite on i386-unknown-openbsd3.5 and i386-unknown-freebsd4.7 which both use GCC 2.95.3/4 as their system compiler. I think these are fine since the code is never used. I'm more worried about GCC 3.1/3.2. Those compilers are in pretty wide use. Or with a program that uses a lot of floating point. That shouldn't be too relevant. I mean, if they were broken before the patch, they're probably still broken. But that doesn't really matter for the branch, does it? Personally I'd like to wait for another two weeks, before deciding it's ok. I'd be willing to check it in on the branch *now* if we'd agree we'd release 6.2.1 after that period. That gives me the oportunity to pull it out if any problems arise. Mark