From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Cc: Andrew Cagney <cagney@redhat.com>,
Peter Schauer <Peter.Schauer@regent.e-technik.tu-muenchen.de>,
Kevin Buettner <kevinb@redhat.com>
Subject: [RFC/AIX] xm-aix4.h - Move some host-specific stuff
Date: Sun, 08 Aug 2004 05:14:00 -0000 [thread overview]
Message-ID: <20040808051420.GH24160@gnat.com> (raw)
The last part of config/xm-aix4.h contains the following definitions:
| /* Signal handler for SIGWINCH `window size changed'. */
|
| #define SIGWINCH_HANDLER aix_resizewindow
| extern void aix_resizewindow (int);
|
| /* `lines_per_page' and `chars_per_line' are local to utils.c. Rectify this. */
| #define SIGWINCH_HANDLER_BODY \
| \
| /* Respond to SIGWINCH `window size changed' signal, and reset GDB's \
| window settings appropriately. */ \
| \
| void \
| aix_resizewindow (signo) \
| int signo; \
| { \
| int fd = fileno (stdout); \
| if (isatty (fd)) { \
| int val; \
| \
| val = atoi (termdef (fd, 'l')); \
| if (val > 0) \
| lines_per_page = val; \
| val = atoi (termdef (fd, 'c')); \
| if (val > 0) \
| chars_per_line = val; \
| } \
| }
Not sure how to handle this part...
First problem: SIGWINCH_HANDLER is used in several files. So when
we define SIGWINCH_HANDLER, we also need to make sure that the prototype
of the procedure it has been defined to is placed somewhere these files
can see them.
Second problem: The body of aix_resizewindow() needs to be moved
somewhere aix-host-specific. Do we have a mechanism for storing
host-specific code? *-nat files, maybe (I wouldn't think so).
Moving that body would allow us to get rid of SIGWINCH_HANDLER_BODY.
If we had a location that would be host-specific to AIX, I would do
the following: Declare in one of .h files a variable, initialized
to NULL, that would be a pointer to the SIGWINCH event. Then, initialize
this variable to aix_resizewindow during the initialization phase
of that aix file. Then modify all the users of this macro from
#ifdef SIGWINCH_HANDLER
do_something_with (SIGWINCH_HANDLER);
#endif
to code like this:
if (sigwinch_handler != NULL)
do_something_with (SIGWINCH_HANDLER);
--
Joel
next reply other threads:[~2004-08-08 5:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-08 5:14 Joel Brobecker [this message]
2004-08-08 12:41 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040808051420.GH24160@gnat.com \
--to=brobecker@gnat.com \
--cc=Peter.Schauer@regent.e-technik.tu-muenchen.de \
--cc=cagney@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox