Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Jim Blandy <jimb@redhat.com>
Cc: gdb-patches@sources.redhat.com, ezannoni@redhat.com
Subject: Re: [rfa/dwarf/doc] Inter-compilation-unit reference support for partial DIEs
Date: Sat, 07 Aug 2004 22:01:00 -0000	[thread overview]
Message-ID: <20040807220115.GA25874@nevyn.them.org> (raw)
In-Reply-To: <vt2smazvrcv.fsf@zenia.home>

On Fri, Aug 06, 2004 at 05:22:56PM -0500, Jim Blandy wrote:
> 
> Daniel Jacobowitz <drow@false.org> writes:
> > So I can merge the two structures if you would like.  I can't think of
> > any fundamental problem.
> 
> This would also remove the special case for the stack-allocated
> compilation unit structure in dwarf2_build_psymtabs_hard, right?

No, that's a different thing entirely.  The only way to get rid of it
would be to stop stack-allocating it, and allocate/free it each time
through the loop.

The more I look at it the less inclined I am to merge dwarf2_cu and
dwarf2_per_cu_data; I'd rather find acceptable names for them.  The
dwarf2_per_cu_data is all the information we need to keep for every
compilation unit, including the not-read-in ones.  The dwarf2_cu is all
the information we need to keep around for read-in ones.  I like the
explicit separation.

The only thing weird about the list manipulation is, well, the list
pointer is only needed for read-in ones... so it went in the second
structure.

How do you feel about this?

-- 
Daniel Jacobowitz


  reply	other threads:[~2004-08-07 22:01 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-20 17:09 Daniel Jacobowitz
2004-04-20 19:43 ` Eli Zaretskii
2004-04-22 22:15 ` Jim Blandy
2004-06-17  3:42 ` Daniel Jacobowitz
2004-06-17  4:19   ` Eli Zaretskii
2004-06-17  4:21     ` Daniel Jacobowitz
2004-06-17  4:26       ` Eli Zaretskii
2004-07-15 18:45   ` Daniel Jacobowitz
2004-07-16 11:18     ` Eli Zaretskii
2004-08-04 23:07     ` Daniel Jacobowitz
2004-08-05 17:23       ` Jim Blandy
2004-08-05 18:05         ` Daniel Jacobowitz
2004-08-06 22:25           ` Jim Blandy
2004-08-07 22:01             ` Daniel Jacobowitz [this message]
2004-08-08  4:42               ` Jim Blandy
2004-08-08 18:17                 ` Daniel Jacobowitz
2004-08-08 19:30                   ` Daniel Jacobowitz
2004-08-10  0:24                     ` Jim Blandy
2004-08-06 22:28           ` Jim Blandy
2004-08-06 22:58           ` Jim Blandy
2004-08-07  0:05           ` Jim Blandy
2004-09-16 21:15 ` Daniel Jacobowitz
2004-09-20 16:41   ` Daniel Jacobowitz
2004-09-20 20:28   ` Jim Blandy
2004-09-20 23:59     ` Daniel Jacobowitz
2004-04-22 22:58 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040807220115.GA25874@nevyn.them.org \
    --to=drow@false.org \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox