Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <kettenis@chello.nl>
To: nathanw@wasabisystems.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] bsd-kvm.c: get exec file name
Date: Fri, 06 Aug 2004 21:13:00 -0000	[thread overview]
Message-ID: <200408062113.i76LDJ4c022596@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <mtuvffwb0sr.fsf@contents-vnder-pressvre.mit.edu> (nathanw@wasabisystems.com)

   From: "Nathan J. Williams" <nathanw@wasabisystems.com>
   Date: 06 Aug 2004 14:04:36 -0400


   This changes bsd_kvm_open() to pass the exec file in use to
   kvm_openfiles() rather than NULL, which improves results when you run
   "gdb /some/other/kernel" "target kvm kernel.core".

   2004-08-06  Nathan J. Williams  <nathanw@wasabisystems.com>

	   * bsd-kvm.c: Include "gdbcore.h"
	   (bsd_kvm_open): Delete variable 'execfile'. Pass return value of 
	   get_exec_file() to kvm_openfiles().

   OK to commit?

OK, although I'd prefer to keep using the variable execfile instead of
wrapping the kvm_openfiles call:

  execfile = get_exec_file (0);
  temp_kd = kvm_openfiles (execfile, filename, NULL, O_RDONLY, errbuf);

Mark


  reply	other threads:[~2004-08-06 21:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-06 18:13 Nathan J. Williams
2004-08-06 21:13 ` Mark Kettenis [this message]
2004-08-07 21:25   ` Nathan J. Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200408062113.i76LDJ4c022596@elgar.kettenis.dyndns.org \
    --to=kettenis@chello.nl \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nathanw@wasabisystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox