From: Joel Brobecker <brobecker@gnat.com>
To: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Cc: Mark Kettenis <kettenis@chello.nl>,
binutils@sources.redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [RFA] MIPS_TEXT symbols should be associated to .text section?
Date: Fri, 30 Jul 2004 18:19:00 -0000 [thread overview]
Message-ID: <20040730181916.GS1167@gnat.com> (raw)
In-Reply-To: <20040730003138.GU965@rembrandt.csv.ica.uni-stuttgart.de>
Thiemo,
One more thing I forgot about your patch:
> case SHN_MIPS_DATA:
> - asym->section = mips_elf_data_section_ptr;
> + {
> + asection *section = elf_tdata (abfd)->elf_data_section;
> +
> + BFD_ASSERT (SGI_COMPAT (abfd));
> + if (section != NULL)
> + asym->section = section;
> + }
> break;
I think that addresses for MIPS_DATA symbols follow the same rule
as in MIPS_TEXT: These are absolute addresses, so we need to substract
the section base address as well, to turn them into offsets. I verified
this empirically by inspecting an executable that had some MIPS_DATA
symbols.
--
Joel
next prev parent reply other threads:[~2004-07-30 18:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-21 20:46 Joel Brobecker
2004-07-29 22:02 ` Joel Brobecker
2004-07-29 22:19 ` Thiemo Seufer
2004-07-29 23:15 ` Mark Kettenis
2004-07-30 0:31 ` Thiemo Seufer
2004-07-30 11:32 ` Eli Zaretskii
2004-07-30 13:37 ` Andrew Cagney
2004-07-30 18:04 ` Eli Zaretskii
2004-07-30 18:13 ` Joel Brobecker
2004-07-30 18:44 ` Eli Zaretskii
2004-07-30 18:55 ` Joel Brobecker
2004-07-30 19:36 ` Eli Zaretskii
2004-07-30 19:59 ` Andrew Cagney
2004-07-30 22:29 ` Michael Chastain
2004-07-30 18:08 ` Joel Brobecker
2004-07-30 18:57 ` Thiemo Seufer
2004-07-30 21:08 ` Mark Kettenis
2004-07-30 23:03 ` Joel Brobecker
2004-07-30 23:57 ` Thiemo Seufer
2004-07-30 18:19 ` Joel Brobecker [this message]
2004-07-30 0:17 ` Joel Brobecker
2004-07-22 15:47 David Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040730181916.GS1167@gnat.com \
--to=brobecker@gnat.com \
--cc=binutils@sources.redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=ica2_ts@csv.ica.uni-stuttgart.de \
--cc=kettenis@chello.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox