From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28720 invoked by alias); 30 Jul 2004 00:01:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28712 invoked from network); 30 Jul 2004 00:01:50 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.77.109) by sourceware.org with SMTP; 30 Jul 2004 00:01:50 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i6U01lJ8018651; Fri, 30 Jul 2004 02:01:47 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i6U01lMA024714; Fri, 30 Jul 2004 02:01:47 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i6U01lT5024711; Fri, 30 Jul 2004 02:01:47 +0200 (CEST) Date: Fri, 30 Jul 2004 00:01:00 -0000 Message-Id: <200407300001.i6U01lT5024711@elgar.kettenis.dyndns.org> From: Mark Kettenis To: cagney@gnu.org CC: gdb-patches@sources.redhat.com In-reply-to: <410988A7.9000706@gnu.org> (message from Andrew Cagney on Thu, 29 Jul 2004 19:30:47 -0400) Subject: Re: [commit] Eliminate add_setshow_cmd References: <41080269.5000100@gnu.org> <200407292323.i6TNN0Ij024552@elgar.kettenis.dyndns.org> <410988A7.9000706@gnu.org> X-SW-Source: 2004-07/txt/msg00478.txt.bz2 Date: Thu, 29 Jul 2004 19:30:47 -0400 From: Andrew Cagney > From: Andrew Cagney > Date: Wed, 28 Jul 2004 15:45:45 -0400 > > Hello, > > This patch eliminates add_setshow_cmd replacing it with the more > formally typed add_setshow_string_cmd and add_setshow_filename_cmd (also > add_setshow_zinteger_cmd in a few places). > > Andrew, did you run the testsuite after making these changes? I now see: > > FAIL: gdb.base/help.exp: help set complaints > > and > > FAIL: gdb.base/help.exp: help show complaints > > so it looks like the output has changed in some subtle way. I did, but looks like I didn't look close enough at the results. Which system? OpenBSD/sparc64, OpenBSD/amd64, FreeBSD/i386. In-tree dejagnu on the latter two, dejagnu 1.4.3 with expect 5.39.0 on OpenBSD/sparc64. Mark