From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27539 invoked by alias); 29 Jul 2004 22:19:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27523 invoked from network); 29 Jul 2004 22:19:11 -0000 Received: from unknown (HELO iris1.csv.ica.uni-stuttgart.de) (129.69.118.2) by sourceware.org with SMTP; 29 Jul 2004 22:19:11 -0000 Received: from rembrandt.csv.ica.uni-stuttgart.de ([129.69.118.42] ident=mail) by iris1.csv.ica.uni-stuttgart.de with esmtp id 1BqJEv-0007eK-00; Fri, 30 Jul 2004 00:19:05 +0200 Received: from ica2_ts by rembrandt.csv.ica.uni-stuttgart.de with local (Exim 3.35 #1 (Debian)) id 1BqJEu-0004lM-00; Fri, 30 Jul 2004 00:19:04 +0200 Date: Thu, 29 Jul 2004 22:19:00 -0000 To: Joel Brobecker Cc: binutils@sources.redhat.com, gdb-patches@sources.redhat.com Subject: Re: [RFA] MIPS_TEXT symbols should be associated to .text section? Message-ID: <20040729221904.GT965@rembrandt.csv.ica.uni-stuttgart.de> References: <20040721204604.GN1278@gnat.com> <20040729220156.GK1167@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040729220156.GK1167@gnat.com> User-Agent: Mutt/1.5.6i From: Thiemo Seufer X-SW-Source: 2004-07/txt/msg00463.txt.bz2 Joel Brobecker wrote: > Hello BFD maintainers, > > Ping? This patch is only 8 days old, and I wouldn't send a reminder > just a week after sending it, but GDB is completely broken without > this patch (ie "break main; run" doesn't work)... Would somebody mind > having a look at it and tell me if it is good or not? [snip] > > @@ -4192,6 +4192,20 @@ _bfd_mips_elf_symbol_processing (bfd *ab > > asym->section = bfd_und_section_ptr; > > break; > > > > + case SHN_MIPS_TEXT: > > + { > > + asection *section = bfd_get_section_by_name (abfd, ".text"); > > + if (section != NULL) > > + { > > + asym->section = section; > > + /* MIPS_TEXT is a bit special, the address is not an offset > > + to the base of the .text section. So substract the section > > + base address to make it an offset. */ > > + asym->value -= section->vma; > > + } > > + break; > > + } > > + > > #if 0 /* for SGI_COMPAT */ > > case SHN_MIPS_TEXT: > > asym->section = mips_elf_text_section_ptr; The last three lines in this patch suggest AFAICS to use mips_elf_text_section_ptr instead of bfd_get_section_by_name, and to make the test conditional on SGI_COMPAT. The SHN_MIPS_DATA below should probably get handled similiarily. Thiemo