From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15660 invoked by alias); 27 Jul 2004 23:27:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15652 invoked from network); 27 Jul 2004 23:27:46 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 27 Jul 2004 23:27:46 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1BpbL8-0008Rm-6w; Tue, 27 Jul 2004 19:26:34 -0400 Date: Tue, 27 Jul 2004 23:27:00 -0000 From: Daniel Jacobowitz To: Jeff Johnston Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA]: threaded watchpoint test Message-ID: <20040727232634.GA32379@nevyn.them.org> Mail-Followup-To: Jeff Johnston , gdb-patches@sources.redhat.com References: <4106A553.7010202@redhat.com> <20040727230053.GA31203@nevyn.them.org> <4106E42F.3010304@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4106E42F.3010304@redhat.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-07/txt/msg00407.txt.bz2 On Tue, Jul 27, 2004 at 07:24:31PM -0400, Jeff Johnston wrote: > Daniel Jacobowitz wrote: > >On Tue, Jul 27, 2004 at 02:56:19PM -0400, Jeff Johnston wrote: > > > >>+# Watch values that will be modified by distinct threads. > >>+gdb_test "watch args\[0\]" "Hardware watchpoint 2: args\\\[0\\\]" > >>+gdb_test "watch args\[1\]" "Hardware watchpoint 3: args\\\[1\\\]" > > > > > >What about platforms without hardware watchpoints? This test will > >generate a lot of FAILs in that case. > > > > I mentioned this both in my original posting and in the test case itself. > There is a test for hardware watchpoints and if there are no hardware > watchpoints, it returns 0. > > # This test verifies that a watchpoint is detected in the proper thread > # so the test is only meaningful on a system with hardware watchpoints. > if [target_info exists gdb,no_hardware_watchpoints] { > return 0; > } OK. Unfortunately I don't think this test is conclusive; unix.exp will always claim to have hardware watchpoints, and on many systems it does not (for instance powerpc-linux). If that turns out to be true we can introduce gdb_has_hardware_watchpoints or something along those lines. -- Daniel Jacobowitz