Re: [RFA/dwarf2] Small problem scanning line table for included files

Jim Blandy
2004-08-01T07:01:32Z

Joel Brobecker <brobecker@gnat.com> writes:
> > I think you are right. Looking for DW_LNS_set_file was a mistake, since
> > it is not fullproof as you demonstrated above. I looked at the dwarf3
> > (draft7) reference again, and setting that flag everytime we need to
> > record a line seems to be the perfect place to do (it's a bit
> > complicated to explain my resoning, I was concerned mostly because
> > I was a bit fuzzy on certain details which were cleared by rereding
> > the dwarf3 reference document).
> >
> > I shall give this a try, and report back.
>
> This worked beautifully, as expected. Here is a new patch, much simpler.
>
> 2004-07-30 Joel Brobecker <brobecker@gnat.com>
>
> * dwarf2read.c (dwarf_decode_lines): Do not consider the current
> file as included until we record the first line in the linetable.
>
> Tested on x86-linux with a GCC-3.4 based compiler, fixes the following
> two regressions:
>
> sep.exp: list using location inside included file
> sep.exp: breakpoint inside included file
>
> I also verified that this test still passes with GCC 3.2.
> OK to commit?

Yes, please do. Thanks!