From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12572 invoked by alias); 22 Jul 2004 02:39:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12564 invoked from network); 22 Jul 2004 02:39:07 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sourceware.org with SMTP; 22 Jul 2004 02:39:07 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 47CA147D91; Wed, 21 Jul 2004 19:39:07 -0700 (PDT) Date: Thu, 22 Jul 2004 02:39:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: gdb_assert will never be triggered Message-ID: <20040722023907.GV1278@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4i X-SW-Source: 2004-07/txt/msg00305.txt.bz2 Hello, While looking at frame.c:get_prev_frame(), I saw the following: if (this_frame == NULL) { [large comment snip'ed] frame_debug_got_null_frame (gdb_stdlog, this_frame, "this_frame NULL"); return current_frame; } /* There is always a frame. If this assertion fails, suspect that something should be calling get_selected_frame() or get_current_frame(). */ gdb_assert (this_frame != NULL); It looks like the assertion will always be true, due to the block above... Do we want to keep this gdb_assert() call nonetheless? -- Joel