From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23546 invoked by alias); 21 Jul 2004 20:36:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23535 invoked from network); 21 Jul 2004 20:36:25 -0000 Received: from unknown (HELO copland.kettenis.dyndns.org) (82.74.7.234) by sourceware.org with SMTP; 21 Jul 2004 20:36:25 -0000 Received: from copland.kettenis.dyndns.org (kettenis@localhost.kettenis.dyndns.org [127.0.0.1]) by copland.kettenis.dyndns.org (8.13.0/8.13.0) with ESMTP id i6LKaE40002204; Wed, 21 Jul 2004 22:36:14 +0200 (CEST) Received: (from kettenis@localhost) by copland.kettenis.dyndns.org (8.13.0/8.13.0/Submit) id i6LKaE0V009860; Wed, 21 Jul 2004 22:36:14 +0200 (CEST) Date: Wed, 21 Jul 2004 20:36:00 -0000 Message-Id: <200407212036.i6LKaE0V009860@copland.kettenis.dyndns.org> From: Mark Kettenis To: hunt@redhat.com CC: gdb-patches@sources.redhat.com In-reply-to: <1090351011.3030.12.camel@dragon> (hunt@redhat.com) Subject: Re: [RFA] read_reg() patch References: <1090351011.3030.12.camel@dragon> X-SW-Source: 2004-07/txt/msg00287.txt.bz2 From: "Martin M. Hunt" Date: Tue, 20 Jul 2004 12:16:51 -0700 2004-07-20 Kevin Buettner and Martin Hunt * dwarf2-frame.c (read_reg): Add a call to store_unsigned_integer. This extracts the least significant register_size() bits and extends it to the size of a pointer. Without this, big-endian targets where pointer size != register size breaks. The formatting of this ChangeLog entry isn't right. Please look at the existing ChangeLogs to see how you should write them. Also move the explanation of what the code does to the code. The ChangeLog should just say what's changed, not why. I also think that the code itself is pretty unreadable. There are too many nested function calls. I think it could be improved by using a (temporary) local variable to store the result of extract_unsigned_integer(). Mark