Re: Dwarf2 Producer info

Daniel Jacobowitz
2004-07-20T23:18:53Z

On Tue, Jul 20, 2004 at 11:29:58PM +0100, David Lecomber wrote:
> Hi
>
> This is an obvious extension to plug a gap.
>
> I've some more changes to come that make use of this (specifically to
> take account of broken g77) and also fix some longstanding array issues,
> but I'm getting this easy one in the source before inflicting the
> complex one on the world.. if anyone has a sharper eye than me for the
> code formatting rules, please feel free to shout out!

I guess changing behavior based on producer is less gross than a lot of
our existing hacks...
> + const char* producer;
> +

"const char *"

> /* The generic symbol table building routines have separate lists
> for

Please use a mailer which does not line wrap patches.
> + static void set_cu_producer (const char*, struct dwarf2_cu *);

"const char *"

> + if (attr)
> + set_cu_producer (DW_STRING (attr), cu);
> + else
> + set_cu_producer(NULL, cu);

set_cu_producer (NULL, cu);

Is set_cu_producer going to do anything else? Otherwise I don't see
the point of the wrapper function.

--
Daniel Jacobowitz