From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1025 invoked by alias); 15 Jul 2004 18:45:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 976 invoked from network); 15 Jul 2004 18:45:13 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 15 Jul 2004 18:45:13 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1BlBDb-0006ju-UN; Thu, 15 Jul 2004 14:44:32 -0400 Date: Thu, 15 Jul 2004 18:45:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com, jimb@redhat.com, ezannoni@redhat.com Subject: Re: [rfa/dwarf/doc] Inter-compilation-unit reference support for partial DIEs Message-ID: <20040715184431.GA25807@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com, jimb@redhat.com, ezannoni@redhat.com References: <20040420170855.GA31548@nevyn.them.org> <20040617034201.GD23443@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040617034201.GD23443@nevyn.them.org> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-07/txt/msg00187.txt.bz2 Three month ping. On Wed, Jun 16, 2004 at 11:42:02PM -0400, Daniel Jacobowitz wrote: > Two month ping. > > Retested on i686-pc-linux-gnu, no regressions. To my surprise the > patch still applies and works after Joel's psymtab changes. > > I think his approach creates a lot of unnecessary psymtabs; I'll have a > closer look at that when I prepare the next patch in this series. > They're only sort of unnecessary now, in that we get a psymtab for each > instance of an included header; when used with inter-CU references they > well be completely unnecessary, because we'll have real psymtabs. So > there should be a way to detect that a psymtab containing all the > information of the pseudo-psymtab already exists. > > On Tue, Apr 20, 2004 at 01:08:55PM -0400, Daniel Jacobowitz wrote: > > Dwarf changes OK? Doc changes OK? Comments/suggestions? > > > 2004-04-20 Daniel Jacobowitz > > > > * Makefile.in (dwarf2read.o): Update dependencies. > > * dwarf2read.c: Include "splay-tree.h", "command.h", and > > "gdbcmd.h". > > (struct dwarf2_per_objfile): Add cu_tree and read_in_chain. > > (struct dwarf2_cu): Add read_in_chain, per_cu, last_used, > > mark, and has_form_ref_addr. > > (struct dwarf2_per_cu_data): New. > > (dwarf2_max_cache_age): New. > > (dwarf2_build_psymtabs_hard): Free cached compilation units > > after loading. Create and manage the cu_tree. > > (psymtab_to_symtab_1): Initialize cu. > > (dwarf2_read_abbrevs): Set has_form_ref_addr. > > (find_partial_die): Use dwarf2_find_containing_comp_unit > > and load_comp_unit. > > (free_stack_comp_unit): Update comments. Clear the per-cu > > pointer. Handle aging. > > (dwarf2_find_containing_comp_unit, free_cached_comp_units) > > (age_cached_comp_units, free_one_cached_comp_unit) > > (dwarf2_mark, dwarf2_clear_marks, splay_tree_obstack_allocate) > > (create_comp_unit_tree, load_comp_unit, set_dwarf2_cmdlist) > > (show_dwarf2_cmdlist, set_dwarf2_cmd, show_dwarf2_cmd): New. > > (_initialize_dwarf2_read): Provide "maint set dwarf2 max-cache-age" > > and "maint show dwarf2 max-cache-age". > > * gdbcmd.h (maintenance_set_cmdlist, maintenance_show_cmdlist): New > > externs. > > * maint.c (maintenance_set_cmdlist, maintenance_show_cmdlist): Make > > global. > > > > 2004-04-20 Daniel Jacobowitz > > > > * gdb.texinfo (Maintenance Commands): Document "maint set dwarf2 > > max-cache-age" and "maint show dwarf2 max-cache-age". > > -- > Daniel Jacobowitz > -- Daniel Jacobowitz