From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12478 invoked by alias); 14 Jul 2004 18:20:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12451 invoked from network); 14 Jul 2004 18:20:14 -0000 Received: from unknown (HELO hall.mail.mindspring.net) (207.69.200.60) by sourceware.org with SMTP; 14 Jul 2004 18:20:14 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by hall.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1BkoMX-0005Rp-00; Wed, 14 Jul 2004 14:20:13 -0400 Received: by berman.michael-chastain.com (Postfix, from userid 502) id 4F59C4B104; Wed, 14 Jul 2004 14:20:14 -0400 (EDT) To: cagney@gnu.org, gdb-patches@sources.redhat.com Subject: Re: [rfc] Revamp logical.exp Message-Id: <20040714182014.4F59C4B104@berman.michael-chastain.com> Date: Wed, 14 Jul 2004 18:20:00 -0000 From: mec.gnu@mindspring.com (Michael Elizabeth Chastain) X-SW-Source: 2004-07/txt/msg00166.txt.bz2 The basic idea and the implementation are good. I hand-checked all the data in the tables for correctness. It all looks fine to me. In the test name, could you include something grep'able. So that if someone gets: FAIL: logical.exp: evaluation of x == y, {x = 1, y = 0} They can find the right gdb_test by grepping on the wordage ("evalation of"). Yes, I see that there are only two gdb_test's in the whole file, but I like the test names to have searchable parts. This has been essential to me when finding things in structs.exp. Also please consider adding $val into the test name: FAIL: logical.exp: evaluation of x == y; {x = 1, y = 0}; expected 0 I think that makes it easier to see whether the test is written correctly or not, especially when someone goes to add 50 new tests. And, as always ... did you run it somewhere? Michael C 2004-07-14 Andrew Cagney * gdb.base/logical.exp: Update copyright. (evaluate): New procedure. Use to re-implement tests using several tables.