Re: [RFA] rda/samples: improve memory allocation

Michael Snyder
2004-07-12T23:50:47Z

Michael Elizabeth Chastain wrote:
> Michael Snyder writes:
>
> + #define ALLOC_UNIT 0x1000;
>
> Oops, extra semicolon!
>
> + #define alloc_roundup(LEN) ((LEN / ALLOC_UNIT) + ALLOC_UNIT)
>
> This looks like it's missing a multiplication again by ALLOC_UNIT.
> Say, if LEN is 0x3000, then alloc_roundup(LEN) comes out to 0x1003
> which seems weird.
>
> Perhaps:
>
> #define alloc_roundup(LEN) ((((LEN)+ALLOC_UNIT-1) / ALLOC_UNIT) * ALLOC_UNIT)
>
> Or I dunno exactly what you want, but that definition doesn't look
> right. Looks like a missing call to alloc_coffee somewhere ...

Mmm, for some reason, I've always been roundup-challenged.
Withdrawn and re-submitted, with your suggestions. Thanks.

[msnyder@dhcp-172-16-25-160 samples]$ make coffee
make: *** No rule to make target `coffee'. Stop.