From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15229 invoked by alias); 8 Jul 2004 03:42:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15217 invoked from network); 8 Jul 2004 03:42:18 -0000 Received: from unknown (HELO mclean.mail.mindspring.net) (207.69.200.57) by sourceware.org with SMTP; 8 Jul 2004 03:42:18 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by mclean.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1BiPnc-0000vC-00; Wed, 07 Jul 2004 23:42:16 -0400 Received: by berman.michael-chastain.com (Postfix, from userid 502) id 5BDA64B104; Wed, 7 Jul 2004 23:42:34 -0400 (EDT) To: cagney@gnu.org, gdb-patches@sources.redhat.com, jjohnstn@redhat.com Subject: Re: [RFA]: Fix jmain.exp to xfail for break at main Message-Id: <20040708034234.5BDA64B104@berman.michael-chastain.com> Date: Thu, 08 Jul 2004 03:42:00 -0000 From: mec.gnu@mindspring.com (Michael Elizabeth Chastain) X-SW-Source: 2004-07/txt/msg00071.txt.bz2 jj> Currently, the gdb.java/jmain.exp test has hard-coded line 6 as the jj> expected line number for a break at jmain.main (java.lang.String[]). jj> This occurs for gcc 3.3 and is incorrect. Line 6 is the end brace for jj> the main routine. As of gcc 3.4, the line number is reported to be line jj> 4. This also isn't what gdb wants as this points to the open brace. jj> The desired result is that we point to line 5 which is the first line in jj> main (return statement). That said, I have changed the expected line to jj> be 5 and set the test as an XFAIL. Dunno what Andrew will say about this patch but I don't think it's good. XFAIL means 'external fail'. If you add an XFAIL to the test suite, I want to see more analysis about what the bug is -- the best thing is an actual gcc PR number. In the gcc PR is a copy of jmain.java and the assembly language output and an explanation of why the assembly language output is incorrect. What does gcc HEAD do? If gcc HEAD actually gives line 5, then I would do this in the test script: # gcc HEAD 2004-07-05 marks the first line as 5, which is correct. # gcc 3.3.4 -gdwarf-2 marks the first line as line 6. # gcc 3.4.1 -gdwarf-2 marks the first line as line 4. set bpmain "Breakpoint .* file .*jmain.java, line 5\." If gcc HEAD gives some other line, then I think you need to file a PR against gcc. It may be low priority and not fixed for years, in which case you can XFAIL the test with that PR number. Michael C === 2004-07-07 Jeff Johnston * gdb.java/jmain.exp: Fix expected line number for main to break at. Set XFAIL for break at main test since gcj does not provide line number info for first statement in main.