Re: [rfa] New test sigbpt.{c,exp}

Michael Elizabeth Chastain
2004-06-30T03:53:17Z

Mostly okay, but there's too many duplicated test names.

% cat gdb.sum | sort | uniq -c | sort -rn
8 PASS: gdb.base/sigbpt.exp: pass SIGSEGV for no breakpoints
7 PASS: gdb.base/sigbpt.exp: rerun to main
4 PASS: gdb.base/sigbpt.exp: continue to keeper for no breakpoints
3 PASS: gdb.base/sigbpt.exp: stepi fault for no breakpoints
3 PASS: gdb.base/sigbpt.exp: continue to breakpoint at fault for no breakpoints
2 PASS: gdb.base/sigbpt.exp: pass SIGSEGV for bp before segv
2 PASS: gdb.base/sigbpt.exp: pass SIGSEGV for bp before and at segv
2 PASS: gdb.base/sigbpt.exp: pass SIGSEGV for bp at segv

Can you make more of the test names more unique?

I'm not worried about stuff like "rerun to main" where if the test
fails then something is really wrong with gdb anyways. I'm more
concerned with multiple identical blocks like this:

gdb_test "handle SIGSEGV nostop print pass" "" "pass SIGSEGV for $name"
gdb_test "continue" "keeper.*" "continue to keeper for $name"
gdb_test "handle SIGSEGV stop print nopass" "" "pass SIGSEGV for $name"

If one of these fails, and all we have is the name of the test
(which is normal), then we don't know which test failed.

Also I'm getting four FAIL results (native i686-pc-linux-gnu,
red hat 8.0, gcc 3.3.3, binutils 2.15, glibc 2.2.93-5-rh,
kernel 2.4.8-14-rh).

FAIL: gdb.base/sigbpt.exp: stepi out of handler for no breakpoints (executed fault insn)
FAIL: gdb.base/sigbpt.exp: stepi out of handler for bp before segv (executed fault insn)
FAIL: gdb.base/sigbpt.exp: stepi out of handler for bp at segv
FAIL: gdb.base/sigbpt.exp: stepi out of handler for bp before and at segv

Is that a fault of the system under test, or a fault of the test script?
Your message implies the former (because it passes with a hacked kernel),
but I just want to check.

Last, a typo:

set test "Verify that SIGSEGV occures at the last STEPI insn"

Michael C