Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Andrew Cagney <cagney@gnu.org>
Cc: Michael Elizabeth Chastain <mec.gnu@mindspring.com>,
	ac131313@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [rfa] New test sigbpt.{c,exp}
Date: Tue, 06 Jul 2004 15:35:00 -0000	[thread overview]
Message-ID: <20040706153509.GA11822@nevyn.them.org> (raw)
In-Reply-To: <40EAC0CF.1060106@gnu.org>

On Tue, Jul 06, 2004 at 11:10:07AM -0400, Andrew Cagney wrote:
> >mec> Can you make more of the test names more unique?
> >ac> Oops, I thought I'd covered that.  Try the attached.
> >
> >It works for me.
> >All the test names are unique except for "rerun to main".
> >Stil the same four FAILs but that's okay because they really are FAILs.
> >
> >I approve this patch.
> >
> >ac> Are there [get_kernel_info] and [get_software_singlestep] testsuite 
> >calls?
> >
> >I don't know of any.
> >
> >I'm a bit leery of "get_kernel_info", because we should be testing
> >for features rather than version numbers (the whole autoconf philosophy).
> >Although get_compiler_info has worked reasonably well for the job
> >that it does.
> >
> >I'm more inclined to dump a bunch of KFAIL's into the gdb_test_multiple
> >arms for the bad results, along with comments about which kernel versions
> >have been observed to have which behavior.  Then in 3-5 years it's not
> >hard to sort out the obsolete crap.
> >
> >If KFAIL's are too hard then just the comments for starters.
> 
> I both kfailed and and commented, committing the attached.

I get:
KFAIL: gdb.base/sigbpt.exp: stepi out of handler; stepi (executed fault insn) (PRMS: gdb/1702)
KFAIL: gdb.base/sigbpt.exp: stepi out of handler; stepi bp before segv (executed fault insn) (PRMS: gdb/1702)
FAIL: gdb.base/sigbpt.exp: stepi out of handler; stepi bp at segv
FAIL: gdb.base/sigbpt.exp: stepi out of handler; stepi bp before and at segv

0x080483f2 in bowler () at /opt/src/gdb/src/gdb/testsuite/gdb.base/sigbpt.c:38
38        return *(char *) (v1 + v2 + v3);
1: x/i $pc  0x80483f2 <bowler+25>:      mov    $0x55c35d00,%esi
(gdb) FAIL: gdb.base/sigbpt.exp: stepi out of handler; stepi bp at segv

That's not the instruction that should be there; there's a multi-byte
instruction at <bowler+24>.  My suspicion is that we single-stepped
with breakpoints inserted and no trap was triggered for the breakpint
at 0x80483f2 for whatever kernel reason.  Make sense?  If so, shall I
try to find a way to kfail this?


-- 
Daniel Jacobowitz


  reply	other threads:[~2004-07-06 15:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-30 18:53 Michael Elizabeth Chastain
2004-07-06 15:10 ` Andrew Cagney
2004-07-06 15:35   ` Daniel Jacobowitz [this message]
2004-07-06 16:00     ` Andrew Cagney
  -- strict thread matches above, loose matches on Subject: below --
2004-07-07 18:39 Michael Elizabeth Chastain
2004-07-06 18:59 Michael Elizabeth Chastain
2004-07-06 19:29 ` Andrew Cagney
2004-07-07 17:31   ` Andrew Cagney
2004-07-08 14:28     ` Daniel Jacobowitz
2004-07-06 18:12 Michael Elizabeth Chastain
2004-07-06 18:30 ` Daniel Jacobowitz
2004-06-30  3:53 Michael Elizabeth Chastain
2004-06-30 15:25 ` Andrew Cagney
2004-06-30 15:30   ` Daniel Jacobowitz
2004-07-02 13:24     ` Andrew Cagney
2004-06-29 23:44 Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040706153509.GA11822@nevyn.them.org \
    --to=drow@false.org \
    --cc=ac131313@redhat.com \
    --cc=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mec.gnu@mindspring.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox